Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"setOrbitPoint" will affect the "dollyToCursor" method cannot be maintained. #424

Open
Innovgame opened this issue Jun 6, 2023 · 7 comments · May be fixed by #507
Open

"setOrbitPoint" will affect the "dollyToCursor" method cannot be maintained. #424

Innovgame opened this issue Jun 6, 2023 · 7 comments · May be fixed by #507

Comments

@Innovgame
Copy link

Innovgame commented Jun 6, 2023

Describe the bug

Hello, I am using camera-controls and want to achieve a function that can always rotate the camera around the origin. Therefore, I used setOrbitPoint. However, I found that the dollyToCursor set during the zoom process became invalid. I am not very familiar with this part of the code and I am not sure if it is a bug. I hope to get your help.

To Reproduce

Steps to reproduce the behavior:

  1. examples/orthographic.html demo
    image
  2. select dollyToCursor
  3. drag
  4. rotate
  5. zoom

Code

No response

Live example

No response

Expected behavior

maintain the effect of dollyToCursor.

Screenshots or Video

bandicam.2023-06-06.10-37-23-333.mp4

Device

Desktop

OS

Windows

Browser

Chrome

@yomotsu
Copy link
Owner

yomotsu commented Jun 6, 2023

Thanks for using camera-controls.
I think that is the known issue, caused by focalOffset

and I can't fix it unfortunately🥲
TBH, I would like to remove setOrbitPoint() and other focalOffset related features...

@Innovgame
Copy link
Author

Thank you for your reply. I have tested it and found that it is indeed related to focalOffset. However, I don't have a good idea on how to solve it yet.

@yomotsu
Copy link
Owner

yomotsu commented Jun 15, 2023

I don't have a good idea on how to solve it yet.

Same here😢

@yomotsu
Copy link
Owner

yomotsu commented Jul 22, 2023

Closing due to lack of feedback.

@yomotsu yomotsu closed this as completed Jul 22, 2023
@vulevukusej
Copy link

@yomotsu does it make sense to close this issue since its still not working?

@yomotsu
Copy link
Owner

yomotsu commented Aug 2, 2023

Oh, sorry it was a mistake...
But unfortunately, I have no plan to fix it because focalOffset which is used in setOrbitPoint causes many other problems.
Hope someone could solve it one day...
Reopening the issue.

@yomotsu yomotsu reopened this Aug 2, 2023
@vulevukusej
Copy link

vulevukusej commented Aug 2, 2023

@yomotsu Yeah I see it's a tricky one. Thanks anyway for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants