Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External search updates automatically look up a word from the beginning of a sentence, can it be disabled? #57

Closed
themoeway-bot opened this issue Mar 5, 2023 · 4 comments
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@themoeway-bot
Copy link
Collaborator

EliCodesForFun opened issue FooSoft/yomichan#420 on 2020-03-24


Here's a video that shows what's happening here.
https://streamable.com/qubx4

On the first sentence, I manually lookup a word.
On the second sentence, Yomichan looks up the first word automatically (Not as I would intend it to do)
On the third sentence, Yomichan proceeds as it should, not looking up any words until specified.

Here are some of my relevant settings:
https://i.imgur.com/1OMwiK6.png
https://i.imgur.com/gCwMZcr.png

@themoeway-bot themoeway-bot added the kind/support The issue is a support request / question label Mar 5, 2023
@themoeway-bot
Copy link
Collaborator Author

siikamiika commented on 2020-03-24


The sentence parsing feature is actually added on top of the original word lookup feature on the search page or native popup. What you're seeing is Yomichan trying to find a word from the beginning of the input string in each case, just with the first third sentences starting with a "「" that isn't a word in the installed dictionaries.

I'm not sure if there's much demand for disabling automatical lookup from the beginning of the input (I could be wrong), but I've thought that it would be less confusing if the result was highlighted so that you'd have a visual cue where the results came from.

@themoeway-bot
Copy link
Collaborator Author

EliCodesForFun commented on 2020-03-24


The sentence parsing feature is actually added on top of the original word lookup feature on the search page or native popup. What you're seeing is Yomichan trying to find a word from the beginning of the input string in each case, just with the first third sentences starting with a "「" that isn't a word in the installed dictionaries.

I'm not sure if there's much demand for disabling automatical lookup from the beginning of the input (I could be wrong), but I've thought that it would be less confusing if the result was highlighted so that you'd have a visual cue where the results came from.

Ohh, I see now. I'm reading a visual novel so it has the Japanese quotes in there.
Yeah I don't really care for the automatic lookup. I'd rather it not show me random words being looked up at the beginning of each sentence, so that I can look it up for specific words I need to lookup. Otherwise it's unneeded bloat and potentially giving me too passive of an experience by translating the first word of each sentence. I have to avert my eyes a bit.

@themoeway-bot
Copy link
Collaborator Author

siikamiika commented on 2020-03-24


Ok, well as a quick workaround if you can modify the settings or source code of the software that you use to copy the visual novel text to the clipboard, you could add some character to the beginning of each line so that it would "mute" the automatic lookups. A potential issue with this approach is that anything you previously had looked up before a new line comes will be lost, but that would have happened anyway.

@Aquafina-water-bottle Aquafina-water-bottle added kind/enhancement The issue or PR is a new feature or request and removed kind/support The issue is a support request / question labels Jun 11, 2023
@jamesmaa
Copy link
Collaborator

Closing this in favor of #1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

3 participants