Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make devtools\statsd-to-stdout.rb a gem executable #33

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

jar349
Copy link
Contributor

@jar349 jar349 commented Apr 6, 2021

Closes #32

This PR makes the statsd-to-stdout.rb usable by consumers by moving it to a bin/ directory and specifying it as an executable in the gemspec.

Documentation is also updated to indicate how to install and use the binstub.

@yob
Copy link
Owner

yob commented Apr 6, 2021 via email

@yob
Copy link
Owner

yob commented Apr 7, 2021

Oh, now that I'm at a computer I've read #32 properly.

I don't think I'd be keen on officially recommending the pattern you've described there, but it's totally a valid thing to do if it works for you! I can't see any downsides to this PR either, so I'm happy to merge it. Thanks!

@yob yob merged commit d81d72f into yob:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin should not fail if no statsd server is available
2 participants