Implement bytemuck traits for other common types
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de ``serde`` to newer version.
|
Hm seems like the CI itself fails. Pretty odd |
|
Hey, sorry for the delay, thanks for submitting this PR, it looks good. I have no idea what caused the appveyor failure even after seeing the logs. What I'm going to do is merge this regardless, compile locally, and if it works I'll push a new version with this change. |
yoanlcq
added a commit
that referenced
this pull request
Jul 16, 2023
yoanlcq
added a commit
that referenced
this pull request
Jul 16, 2023
|
Done, available in 0.16.0 |
|
Ah shoot it doesn't compile with the |
|
No problem, I'll refer #94 from here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
ZeroableandPodfor allVec<T>types and their variants (simd and repr_c),Mat4<T>s, and forQuaternion