Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Alpine breaks this #3

Open
SaaSNSY opened this issue May 31, 2024 · 5 comments
Open

Latest Alpine breaks this #3

SaaSNSY opened this issue May 31, 2024 · 5 comments

Comments

@SaaSNSY
Copy link

SaaSNSY commented May 31, 2024

This works fine on alpine:3.18
Git clone fails on alpine:latest with fatal: the remote end hung up unexpectedly
More details when I have them.

@SaaSNSY
Copy link
Author

SaaSNSY commented Jun 1, 2024

It seems to need git config --system --add safe.directory * or some variant thereof.

@SaaSNSY
Copy link
Author

SaaSNSY commented Jun 1, 2024

It would also be helpful to to have the -f flag on fcgiwrap so that errors from git-http-backend aren't lost and errors sent to stderr, so they are visible in the docker logs.

@SaaSNSY
Copy link
Author

SaaSNSY commented Jun 3, 2024

It turns out that the version that fails is slightly modified and an unchanged version works. I would still suggest that it the -f flag on fcgiwrap -f would be a good change so that errors thrown by git-htttp-backend will be logged. I would also suggest using access_log stderr and error_log stderr so that activity and errors appear in the docker logs.

@SaaSNSY SaaSNSY closed this as completed Jun 3, 2024
@ynohat
Copy link
Owner

ynohat commented Jun 3, 2024

Hi @SaaSNSY thanks a lot for your time investigating this.
I suggest we reopen so I can examine the rest of your feedback. To be perfectly frank I am no longer using this nor actively maintaining, but I'm happy to make some changes if they are useful to someone.

@ynohat ynohat reopened this Jun 3, 2024
@SaaSNSY
Copy link
Author

SaaSNSY commented Jun 3, 2024

The thing that breaks it, is the combination of the fix for CVE-2022-24765 combined with running as a non root user. As your runs as root, I would suggest a note in the README for anyone trying to use non root users that it requires git config --system --add safe.directory * or some variant thereof. The other suggestions would be helpful for anyone needing to debug any breakages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants