fix(xmlhttprequest): replace to req.destroy from req.abort (#100)

Author: ykzts

src/xmlhttprequest.ts

@@ -200,11 +200,22 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget {
    */
   abort(): void {
     if (
-      this.readyState === XMLHttpRequest.HEADERS_RECEIVED ||
-      this.readyState === XMLHttpRequest.LOADING
+      this.readyState === XMLHttpRequest.UNSENT ||
+      this.readyState === XMLHttpRequest.OPENED ||
+      this.readyState === XMLHttpRequest.DONE ||
+      !this.#client
     ) {
-      this.#client?.abort();
+      return;
     }
+
+    this.#client.destroy();
+
+    this.#readyState = XMLHttpRequest.UNSENT;
+
+    this.dispatchEvent(new ProgressEvent('abort'));
+    this.upload.dispatchEvent(new ProgressEvent('abort'));
+
+    this.#client = null;
   }
 
   /**
@@ -314,14 +325,6 @@ export default class XMLHttpRequest extends XMLHttpRequestEventTarget {
       protocol
     });
 
-    this.#client.addListener('abort', () => {
-      this.dispatchEvent(new ProgressEvent('abort'));
-      this.upload.dispatchEvent(new ProgressEvent('abort'));
-
-      this.#client = null;
-      this.#readyState = XMLHttpRequest.UNSENT;
-    });
-
     this.#client.addListener('error', () => {
       this.dispatchEvent(new ProgressEvent('error'));
       this.upload.dispatchEvent(new ProgressEvent('error'));

test/integration/xmlhttprequest.ts

@@ -65,6 +65,25 @@ describe('XMLHttpRequest', () => {
     baseURL = null;
   });
 
+  describe('abort()', () => {
+    it('basic use case', (done) => {
+      const client = new XMLHttpRequest();
+
+      client.addEventListener('abort', (event) => {
+        expect(event.type).toBe('abort');
+        expect(client.readyState).toBe(XMLHttpRequest.UNSENT);
+
+        done();
+      });
+      client.addEventListener('loadstart', () => {
+        client.abort();
+      });
+
+      client.open('GET', `${baseURL}/?body=abort`);
+      client.send();
+    });
+  });
+
   describe("addEventListener(event: 'error')", () => {
     it('basic use case', (done) => {
       const client = new XMLHttpRequest();