From db144edadc0b23f2ba1e7c6b98c67de61c308566 Mon Sep 17 00:00:00 2001 From: Yauheni Kaliuta Date: Fri, 16 Aug 2024 07:39:06 +0300 Subject: [PATCH] kserve: do not call ApplyParams for the empty list (#1179) The call is not need since the code just declare empty parameters list: var imageParamMap = map[string]string{} Fixes the issue of calling ApplyParams for non-enabled case. Signed-off-by: Yauheni Kaliuta --- components/kserve/kserve.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/components/kserve/kserve.go b/components/kserve/kserve.go index 72fb0b1e9fa..11b476dae84 100644 --- a/components/kserve/kserve.go +++ b/components/kserve/kserve.go @@ -97,8 +97,6 @@ func (k *Kserve) GetComponentName() string { func (k *Kserve) ReconcileComponent(ctx context.Context, cli client.Client, logger logr.Logger, owner metav1.Object, dscispec *dsciv1.DSCInitializationSpec, platform cluster.Platform, _ bool) error { l := k.ConfigComponentLogger(logger, ComponentName, dscispec) - // paramMap for Kserve to use. - var imageParamMap = map[string]string{} // dependentParamMap for odh-model-controller to use. var dependentParamMap = map[string]string{ @@ -125,13 +123,6 @@ func (k *Kserve) ReconcileComponent(ctx context.Context, cli client.Client, } } - // Update image parameters only when we do not have customized manifests set - if (dscispec.DevFlags == nil || dscispec.DevFlags.ManifestsUri == "") && (k.DevFlags == nil || len(k.DevFlags.Manifests) == 0) { - if err := deploy.ApplyParams(Path, imageParamMap, false); err != nil { - return fmt.Errorf("failed to update image from %s : %w", Path, err) - } - } - if err := k.configureServiceMesh(ctx, cli, dscispec); err != nil { return fmt.Errorf("failed configuring service mesh while reconciling kserve component. cause: %w", err) }