Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Same Window Shadow defaults as system defaults #11

Closed
seanleavy opened this issue Aug 3, 2022 · 3 comments · Fixed by #30
Closed

Feature Request - Same Window Shadow defaults as system defaults #11

seanleavy opened this issue Aug 3, 2022 · 3 comments · Fixed by #30
Labels
enhancement New feature or request

Comments

@seanleavy
Copy link

First all well done. Absolutely class work.

Just wanted to request the below. Feel free to close this if you dont wish to.

  • Ability to restore default settings via GUI.
  • Match the extension 'Window Shadow' defaults to the system defaults (ie. focused & unfocused window shadows are the same whether this extension is enabled or not) OR just have a toggle to ignore the 'Window Shadow' settings.

Thanks again for the contribution 👍 .

@seanleavy seanleavy changed the title Feature Request - Same defualts as when disabled Feature Request - Same Window Shadow defaults as system defaults Aug 3, 2022
@yilozt
Copy link
Owner

yilozt commented Aug 3, 2022

The default style of window can be found in Gtk project:

https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/theme/Default/_common.scss#L4053

We can use it as default style of custom shadow.

We have to add a custom shadow behind windows, because original shadow has been cut out, so ignore the 'Window Shadow' is impossible.

Restore default settings is a good idea, I will add it to prefs.

@julianfairfax
Copy link

Yeah I agree defaults should be an option. Because otherwise it looks weird.

@yilozt yilozt added the enhancement New feature or request label Aug 3, 2022
@yilozt
Copy link
Owner

yilozt commented Aug 8, 2022

Should be implemented in #30, There is the shadow looks like when enable / disable this extensions:

Peek.2022-08-08.14-53.mp4

@yilozt yilozt closed this as completed in #30 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants