Bootstrap nav

[aripjanovsh]

use yii\bootstrap\Nav;
$items = [
    [
        'label' => 'test 1',
        'url' => 'test',
        'items' => [
            [
                'label' => 'test 1.1',
                'url' => 'test 1.1',
                'items' => [
                    [
                        'label' => 'test 1.1.1',
                        'url' => 'test 1.1.1'
                    ],
                    [
                        'label' => 'test 1.1.2',
                        'url' => 'test 1.1.2'
                    ],
                ]
            ]
        ]
    ]
];

echo Nav::widget([
    'id' => 'topmenuleft',
    'options' => ['class' => 'navbar-nav navbar-left'],
    'items' => $items
]);

output is not correct

<ul id="topmenuleft" class="navbar-nav navbar-left nav">
    <li class="dropdown"><a class="dropdown-toggle" href="/backend/web/test" data-toggle="dropdown">test 1 <b
                class="caret"></b></a>
        <ul id="w0" class="dropdown-menu">
            <li class="dropdown-submenu"><a href="/backend/web/test 1.1" tabindex="-1">test 1.1</a>
                <ul id="w0" class="dropdown-menu">
                    <li><a href="/backend/web/test 1.1.1" tabindex="-1">test 1.1.1</a></li>
                    <li><a href="/backend/web/test 1.1.2" tabindex="-1">test 1.1.2</a></li>
                </ul>
            </li>
        </ul>
    </li>
</ul>

identical ids id="w0" , and dropdown-submenu not working
p.s. sorry for my english :)

[klevron]

Confirmed.

But submenus support in dropdown has been removed in BS3 :

Submenus just don't have much of a place on the web right now, especially the mobile web. They will be removed with 3.0 (twbs/bootstrap#6342)

http://stackoverflow.com/questions/18023493/bootstrap-3-dropdown-sub-menu-missing

[cebe]

But submenus support in dropdown has been removed in BS3 :

yeah but Nav widgets supports them. This issue is about the auto generated ids which are wrong.

[DrMabuse23]

@aripjanovsh maybe this helps you out https://github.com/brewing/yii2-foundation-topbar

[samdark]

I confirm the issue.

[arturf]

@cebe, @samdark

https://github.com/yiisoft/yii2/blob/master/extensions/bootstrap/Dropdown.php#L90

changing recursion call

$content .= $this->renderItems($item['items']);

to

$content .= static::widget([
    'items' => $item['items'],
]);

fixes problem with ids. Submit pull request?

[samdark]

Yes.

[samdark]

Fixed.

[qiangxue]

See my comment here: #4354 (comment)

[kartik-v]

With reference to commit e6be9fd, I maybe missing something. But I do not see containerOptions being used anywhere in the code for generating any markup. What's the purpose of this, as it causes no impact to anything yet?

Is it just to help subclass or help extend the widget?

Or do you need this to be merged with item['options']?

[samdark]

The purpose is to apply it to container but not to subtags.

[kartik-v]

Ok... but if I check the Dropdown widget code, containerOptions is not used or applied anywhere.

[samdark]

Try it.

[kartik-v]

I understand the recursive call and it does work (for unsetting the containerOptions['id'] after first run). But just trying to understand. The only HTML markup that uses containerOptions is this line:

return Html::tag('ul', implode("\n", $lines), $this->options);

and it does not use

return Html::tag('ul', implode("\n", $lines), $containerOptions);

Is the above correct? If so, using another class level private variable $this->_containerOptions that defaults to $this->options and with unset('id'), instead of using a function parameter $containerOptions in the renderItems method is an alternative.

[samdark]

Yes, it can be done that way.

[kartik-v]

Ok. It may be better for not breaking BC.

[samdark]

@kartik-v can you help with testing it and a pull request?