Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt to router changes #143

Open
samdark opened this issue Nov 22, 2021 · 2 comments
Open

Adopt to router changes #143

samdark opened this issue Nov 22, 2021 · 2 comments
Labels
status:ready for adoption Feel free to implement this issue. type:docs Documentation

Comments

@samdark
Copy link
Member

samdark commented Nov 22, 2021

yiisoft/router#128

Route arguments should be taken from CurrentRoute now, not from request.
@samdark
Copy link
Member Author

samdark commented Nov 22, 2021

Done in general but need to mention it specifically in request-response description and have it more explicit in router.

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Nov 22, 2021
@rustamwin
Copy link
Member

rustamwin commented Nov 22, 2021 •
edited by samdark
Loading

Also need document

@samdark samdark added the type:docs Documentation label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue. type:docs Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @rustamwin