Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI new pull request always fails? #52

Open
nahakyuu opened this issue Jun 10, 2023 · 6 comments
Open

CI new pull request always fails? #52

nahakyuu opened this issue Jun 10, 2023 · 6 comments
Labels
status:to be verified Needs to be reproduced and validated.

Comments

@nahakyuu
Copy link

https://github.com/yiisoft/yii-debug-api/actions/workflows/rector.yml?query=is%3Afailure

@rustamwin rustamwin added the status:to be verified Needs to be reproduced and validated. label Jun 10, 2023
@vjik
Copy link
Member

vjik commented Jun 10, 2023

Rector workflow make commit and now fail on pull request from forks.

Can you try change /.github/workflow/rector.yml in your PR to this code:

on:
  pull_request:
    paths-ignore:
      - 'docs/**'
      - 'README.md'
      - 'CHANGELOG.md'
      - '.gitignore'
      - '.gitattributes'
      - 'infection.json.dist'
      - 'psalm.xml'

name: rector

jobs:
  rector:
    uses: yiisoft/actions/.github/workflows/rector.yml@master
    secrets:
      token: ${{ secrets.YIISOFT_GITHUB_TOKEN }}
    with:
      os: >-
        ['ubuntu-latest']
      php: >-
        ['8.0']

?

@samdark
Copy link
Member

samdark commented Jun 10, 2023

YIISOFT_GITHUB_TOKEN isn't passed to forks.

@samdark
Copy link
Member

samdark commented Jun 10, 2023

I think it's a good idea to fall back to regular GitHub token if YIISOFT_GITHUB_TOKEN isn't available.

@vjik
Copy link
Member

vjik commented Jun 10, 2023

But it's should be available in PR to origin repository

@samdark
Copy link
Member

samdark commented Jun 10, 2023

No.

image

@vjik
Copy link
Member

vjik commented Jun 11, 2023

Fall back already exist...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:to be verified Needs to be reproduced and validated.
Projects
None yet
Development

No branches or pull requests

4 participants