Problem: panic on invalid elasticity_multiplier (#472)

* Problem: panic on invalid elasticity_multiplier

* Problem: codecov action v3 is pinging v4 (#458)

Author: mmsqe

.github/workflows/test.yml

@@ -34,7 +34,7 @@ jobs:
         run: |
           make test-unit-cover
         if: env.GIT_DIFF
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v4
         with:
           file: ./coverage.txt
           fail_ci_if_error: true

CHANGELOG.md

@@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 ### Bug Fixes
 
 * (rpc) [#457](https://github.com/crypto-org-chain/ethermint/pull/457) Add param keytable in evm for old upgrade.
+* (rpc) [#473](https://github.com/crypto-org-chain/ethermint/pull/473) Avoid panic on invalid elasticity_multiplier.
 
 ## v0.21.x-cronos
 

rpc/backend/chain_info.go

@@ -21,9 +21,11 @@ import (
 	"strconv"
 	"sync"
 
+	errorsmod "cosmossdk.io/errors"
 	tmrpcclient "github.com/cometbft/cometbft/rpc/client"
 	tmrpctypes "github.com/cometbft/cometbft/rpc/core/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	errortypes "github.com/cosmos/cosmos-sdk/types/errors"
 	"github.com/ethereum/go-ethereum/common/hexutil"
 	"github.com/ethereum/go-ethereum/common/math"
 	ethtypes "github.com/ethereum/go-ethereum/core/types"
@@ -226,7 +228,14 @@ func (b *Backend) FeeHistory(
 			}
 			wg.Add(1)
 			go func(index int32) {
-				defer wg.Done()
+				defer func() {
+					if r := recover(); r != nil {
+						err = errorsmod.Wrapf(errortypes.ErrPanic, "%v", r)
+						b.logger.Error("FeeHistory panicked", "error", err)
+						chanErr <- err
+					}
+					wg.Done()
+				}()
 				// fetch block
 				// tendermint block
 				blockNum := rpctypes.BlockNumber(blockStart + int64(index))

rpc/backend/chain_info_test.go

@@ -377,6 +377,23 @@ func (suite *BackendTestSuite) TestFeeHistory() {
 			false,
 			nil,
 		},
+		{
+			"fail - Tendermint block fetching panic",
+			func(validator sdk.AccAddress) {
+				client := suite.backend.clientCtx.Client.(*mocks.Client)
+				suite.backend.cfg.JSONRPC.FeeHistoryCap = 2
+				var header metadata.MD
+				queryClient := suite.backend.queryClient.QueryClient.(*mocks.EVMQueryClient)
+				RegisterParams(queryClient, &header, 1)
+				RegisterBlockPanic(client, ethrpc.BlockNumber(1).Int64())
+			},
+			1,
+			1,
+			nil,
+			nil,
+			false,
+			nil,
+		},
 		{
 			"fail - Eth block fetching error",
 			func(validator sdk.AccAddress) {

rpc/backend/client_test.go

@@ -140,6 +140,14 @@ func RegisterBlockNotFound(
 	return &tmrpctypes.ResultBlock{Block: nil}, nil
 }
 
+// Block panic
+func RegisterBlockPanic(client *mocks.Client, height int64) {
+	client.On("Block", rpc.ContextWithHeight(height), mock.AnythingOfType("*int64")).
+		Return(func(context.Context, *int64) *tmrpctypes.ResultBlock {
+			panic("Block call panic")
+		}, nil)
+}
+
 func TestRegisterBlock(t *testing.T) {
 	client := mocks.NewClient(t)
 	height := rpc.BlockNumber(1).Int64()

rpc/backend/utils.go

@@ -23,6 +23,7 @@ import (
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
+	"github.com/pkg/errors"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 
@@ -118,16 +119,18 @@ func (b *Backend) getAccountNonce(accAddr common.Address, pending bool, height i
 }
 
 // CalcBaseFee calculates the basefee of the header.
-func CalcBaseFee(config *params.ChainConfig, parent *ethtypes.Header, p feemarkettypes.Params) *big.Int {
+func CalcBaseFee(config *params.ChainConfig, parent *ethtypes.Header, p feemarkettypes.Params) (*big.Int, error) {
 	// If the current block is the first EIP-1559 block, return the InitialBaseFee.
 	if !config.IsLondon(parent.Number) {
-		return new(big.Int).SetUint64(params.InitialBaseFee)
+		return new(big.Int).SetUint64(params.InitialBaseFee), nil
+	}
+	if p.ElasticityMultiplier == 0 {
+		return nil, errors.New("ElasticityMultiplier cannot be 0 as it's checked in the params validation")
 	}
-
 	parentGasTarget := parent.GasLimit / uint64(p.ElasticityMultiplier)
 	// If the parent gasUsed is the same as the target, the baseFee remains unchanged.
 	if parent.GasUsed == parentGasTarget {
-		return new(big.Int).Set(parent.BaseFee)
+		return new(big.Int).Set(parent.BaseFee), nil
 	}
 
 	var (
@@ -144,7 +147,7 @@ func CalcBaseFee(config *params.ChainConfig, parent *ethtypes.Header, p feemarke
 		num.Div(num, denom.SetUint64(uint64(p.BaseFeeChangeDenominator)))
 		baseFeeDelta := math.BigMax(num, common.Big1)
 
-		return num.Add(parent.BaseFee, baseFeeDelta)
+		return num.Add(parent.BaseFee, baseFeeDelta), nil
 	}
 
 	// Otherwise if the parent block used less gas than its target, the baseFee should decrease.
@@ -155,7 +158,7 @@ func CalcBaseFee(config *params.ChainConfig, parent *ethtypes.Header, p feemarke
 	num.Div(num, denom.SetUint64(uint64(p.BaseFeeChangeDenominator)))
 	baseFee := num.Sub(parent.BaseFee, num)
 	minGasPrice := p.MinGasPrice.TruncateInt().BigInt()
-	return math.BigMax(baseFee, minGasPrice)
+	return math.BigMax(baseFee, minGasPrice), nil
 }
 
 // output: targetOneFeeHistory
@@ -201,7 +204,11 @@ func (b *Backend) processBlock(
 		if err != nil {
 			return err
 		}
-		targetOneFeeHistory.NextBaseFee = CalcBaseFee(cfg, &header, params.Params)
+		nextBaseFee, err := CalcBaseFee(cfg, &header, params.Params)
+		if err != nil {
+			return err
+		}
+		targetOneFeeHistory.NextBaseFee = nextBaseFee
 	} else {
 		targetOneFeeHistory.NextBaseFee = new(big.Int)
 	}

x/feemarket/migrations/v4/types/params.go

@@ -104,6 +104,10 @@ func (p Params) Validate() error {
 		return err
 	}
 
+	if p.ElasticityMultiplier == 0 {
+		return fmt.Errorf("elasticity multiplier cannot be 0")
+	}
+
 	return validateMinGasPrice(p.MinGasPrice)
 }
 
@@ -129,10 +133,13 @@ func validateBaseFeeChangeDenominator(i interface{}) error {
 }
 
 func validateElasticityMultiplier(i interface{}) error {
-	_, ok := i.(uint32)
+	value, ok := i.(uint32)
 	if !ok {
 		return fmt.Errorf("invalid parameter type: %T", i)
 	}
+	if value == 0 {
+		return fmt.Errorf("elasticity multiplier cannot be 0")
+	}
 	return nil
 }
 

x/feemarket/types/params.go

@@ -117,6 +117,10 @@ func (p Params) Validate() error {
 		return err
 	}
 
+	if p.ElasticityMultiplier == 0 {
+		return fmt.Errorf("elasticity multiplier cannot be 0")
+	}
+
 	return validateMinGasPrice(p.MinGasPrice)
 }
 
@@ -164,10 +168,13 @@ func validateBaseFeeChangeDenominator(i interface{}) error {
 }
 
 func validateElasticityMultiplier(i interface{}) error {
-	_, ok := i.(uint32)
+	value, ok := i.(uint32)
 	if !ok {
 		return fmt.Errorf("invalid parameter type: %T", i)
 	}
+	if value == 0 {
+		return fmt.Errorf("elasticity multiplier cannot be 0")
+	}
 	return nil
 }