Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a choice field for SemanticValues in dictionaries #291

Closed
joankaradimov opened this issue Mar 25, 2024 · 1 comment
Closed

Expose a choice field for SemanticValues in dictionaries #291

joankaradimov opened this issue Mar 25, 2024 · 1 comment

Comments

@joankaradimov
Copy link

I notice that the Trie behaves more like a set and its match method returns the match length. Would it be viable to make it behave like a map with its match returning the choice index (that can be kept as an additional field in the Info struct).

I think that would make for a more consistent interface. And allow for more performant grammar handling in certain cases.

@yhirose
Copy link
Owner

yhirose commented Mar 26, 2024

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants