Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client emit close when server return ZNOTHING #221

Closed
DavidVujic opened this issue Aug 31, 2019 · 0 comments
Closed

Client emit close when server return ZNOTHING #221

DavidVujic opened this issue Aug 31, 2019 · 0 comments
Assignees
Labels

Comments

@DavidVujic
Copy link
Collaborator

DavidVujic commented Aug 31, 2019

Describe the bug
A previous fix for issue #172 has caused a new behaviour: occasional close events emitted from the client (the native addon).

Tested with a ZooKeeper server v3.4.8.

To Reproduce
Connect a client and run exist and get actions.

Expected behavior
The addon should handle the ZNOTHING return code. Perhaps implement a counter and emit close after n number of tries?

Desktop (please complete the following information):

  • OS: Mac os x
  • Node.js version: 10
  • C/C++ compiler and version: Apple LLVM v10

Additional context
The bug probably appeared in versions after v4.0.2 of node-zookeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant