Fix TS errors in tests directory (#314)

Fix all TS errors in the `tests` folder. J=SLAP-2360 TEST=manual Go through all files in `tests` and see that there are no more errors.
yext · Oct 13, 2022 · d8e76b9 · d8e76b9
1 parent 776086a
commit d8e76b9
Show file tree

Hide file tree

Showing 35 changed files with 352 additions and 349 deletions.
diff --git a/THIRD-PARTY-NOTICES b/THIRD-PARTY-NOTICES
@@ -406,7 +406,7 @@ Apache License
 
 The following NPM package may be included in this product:
 
- - @reduxjs/[email protected].5
+ - @reduxjs/[email protected].6
 
 This package contains the following license and notice below:
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -52,6 +52,7 @@
     "@babel/preset-typescript": "^7.14.5",
     "@percy/cli": "^1.8.0",
     "@percy/storybook": "^4.3.3",
+    "@reduxjs/toolkit": "^1.8.6",
     "@storybook/addon-a11y": "^6.5.10",
     "@storybook/addon-actions": "^6.5.10",
     "@storybook/addon-coverage": "^0.0.2",

diff --git a/tests/__fixtures__/core/search-service.ts b/tests/__fixtures__/core/search-service.ts
@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-import { SearchService, UniversalSearchRequest, UniversalSearchResponse, VerticalSearchRequest, VerticalSearchResponse } from '@yext/search-core';
+import { SearchService, Source, UniversalSearchRequest, UniversalSearchResponse, VerticalSearchRequest, VerticalSearchResponse } from '@yext/search-core';
 
 /* A sample Universal Search response. */
 const mockedUniversalResponse: UniversalSearchResponse = {
@@ -11,7 +11,14 @@ const mockedUniversalResponse: UniversalSearchResponse = {
 const mockedVerticalResponse: VerticalSearchResponse = {
   uuid: '123',
   queryId: 'query-id',
-  verticalResults: null
+  verticalResults: {
+    appliedQueryFilters: [],
+    queryDurationMillis: 500,
+    verticalKey: 'vertical',
+    results: [],
+    resultsCount: 0,
+    source: 'KNOWLEDGE_MANAGER' as Source
+  }
 };
 
 /**

diff --git a/tests/__fixtures__/data/filtercontext.ts b/tests/__fixtures__/data/filtercontext.ts
@@ -0,0 +1,48 @@
+import { FiltersContextType } from '../../../src/components/Filters/FiltersContext';
+import { SelectableFieldValueFilter } from '../../../src/models/SelectableFieldValueFilter';
+import { FilterGroupContextType } from '../../../src/components/Filters/FilterGroupContext';
+import { Matcher } from '@yext/search-headless-react';
+
+const selectableFilter: SelectableFieldValueFilter = {
+  selected: true,
+  fieldId: '123',
+  matcher: Matcher.Equals,
+  value: 'test'
+};
+
+export const filterContextValue: FiltersContextType = {
+  selectFilter: () => null,
+  applyFilters: () => null,
+  filters: []
+};
+
+export const filterContextValueDisabled: FiltersContextType = {
+  selectFilter: () => null,
+  applyFilters: () => null,
+  filters: [selectableFilter]
+};
+
+export const filterGroupContextValue: FilterGroupContextType = {
+  searchValue: '',
+  fieldId: '123',
+  setSearchValue: () => null,
+  getCollapseProps: () => ({
+    id: 'id',
+    onTransitionEnd: () => null,
+    style: {},
+    'aria-hidden': 'false'
+  }),
+  getToggleProps: () => ({
+    disabled: false,
+    type: 'button',
+    role: 'role',
+    id: 'id',
+    'aria-controls': 'element',
+    'aria-expanded': 'true',
+    tabIndex: 0,
+    onClick: () => null
+  }),
+  isExpanded: true,
+  isOptionsDisabled: false,
+  setIsOptionsDisabled: () => null
+};
diff --git a/tests/__fixtures__/data/filters.ts b/tests/__fixtures__/data/filters.ts
@@ -1,5 +1,6 @@
 import { DisplayableFacet, Matcher, SelectableStaticFilter } from '@yext/search-headless-react';
 import { RemovableFilter } from '../../../src/components/AppliedFiltersDisplay';
+import { StaticFiltersProps } from '../../../src/components/StaticFilters';
 
 function createRemovableFilter(value: string) {
   return {
@@ -96,3 +97,25 @@ export const staticFilters: SelectableStaticFilter[] = [
     selected: false
   }
 ];
+
+export const staticFiltersProps: StaticFiltersProps = {
+  fieldId: 'c_puppyPreference',
+  title: 'Puppy Preference',
+  filterOptions: [
+    {
+      value: 'Marty',
+      displayName: 'MARTY!'
+    },
+    {
+      value: 'Frodo',
+      selectedByDefault: true
+    },
+    {
+      value: 'Bleecker'
+    },
+    {
+      value: 'Clifford',
+      selectedByDefault: false
+    }
+  ]
+};
diff --git a/tests/__fixtures__/state-manager.ts b/tests/__fixtures__/state-manager.ts
@@ -15,7 +15,7 @@ export function generateMockedStateManager(state: State): StateManager {
     }
 
     dispatchEvent(type: string, payload?: unknown): void {
-      return null;
+      return;
     }
 
     addListener<T>(listener: StateListener<T>): Unsubscribe {

diff --git a/tests/__utils__/hierarchicalfacets.ts b/tests/__utils__/hierarchicalfacets.ts
@@ -9,7 +9,7 @@ export function createHierarchicalFacet(
     .map(o => ({
       value: o.value,
       displayName: o.value,
-      selected: o.selected,
+      selected: o.selected ?? false,
       count: 82,
       matcher: Matcher.Equals
     }));
@@ -19,4 +19,4 @@ export function createHierarchicalFacet(
     displayName: 'Fruits',
     options: transformedOptions
   };
-}
+}
diff --git a/tests/__utils__/mocks.ts b/tests/__utils__/mocks.ts
@@ -18,10 +18,10 @@ export function spyOnActions(): jest.Mocked<SearchActions> {
 
 export type RecursivePartial<T> = {
   [P in keyof T]?:
-  T[P] extends (infer U)[] ? RecursivePartial<U>[] :
-    // eslint-disable-next-line @typescript-eslint/ban-types
-    T[P] extends object ? RecursivePartial<T[P]> :
-      T[P];
+  T[P] extends undefined ? undefined :
+    T[P] extends ((infer U)[] | undefined) ? RecursivePartial<U>[] :
+      T[P] extends (object | undefined) ? RecursivePartial<T[P]> :
+        T[P];
 };
 
 export function mockAnswersState(

diff --git a/tests/components/AlternativeVerticals.stories.tsx b/tests/components/AlternativeVerticals.stories.tsx
@@ -1,4 +1,4 @@
-import { ComponentMeta } from '@storybook/react';
+import { ComponentMeta, Story } from '@storybook/react';
 import { SearchHeadlessContext } from '@yext/search-headless-react';
 
 import { AlternativeVerticals, AlternativeVerticalsProps } from '../../src/components/AlternativeVerticals';
@@ -24,33 +24,28 @@ const verticalConfigMap = {
   locations: { label: 'Locations' }
 };
 
-export const Primary = (args: AlternativeVerticalsProps) => {
+export const Primary: Story<AlternativeVerticalsProps> = (args) => {
   return (
     <SearchHeadlessContext.Provider value={generateMockedHeadless(mockedHeadlessState)}>
       <AlternativeVerticals
-        currentVerticalLabel='Jobs'
-        verticalConfigMap={verticalConfigMap}
-        displayAllOnNoResults={false}
         {...args}
       />
     </SearchHeadlessContext.Provider>
   );
 };
+Primary.args = {
+  currentVerticalLabel: 'Jobs',
+  verticalConfigMap,
+  displayAllOnNoResults: false
+};
 
-export const DisplayAllOnNoResults = (args: AlternativeVerticalsProps) => {
-  return (
-    <SearchHeadlessContext.Provider value={generateMockedHeadless(mockedHeadlessState)}>
-      <AlternativeVerticals
-        currentVerticalLabel='Jobs'
-        verticalConfigMap={verticalConfigMap}
-        displayAllOnNoResults={true}
-        {...args}
-      />
-    </SearchHeadlessContext.Provider>
-  );
+export const DisplayAllOnNoResults = Primary.bind({});
+DisplayAllOnNoResults.args = {
+  ...Primary.args,
+  displayAllOnNoResults: true
 };
 
-export const Loading = (args: AlternativeVerticalsProps) => {
+export const Loading: Story<AlternativeVerticalsProps> = (args) => {
   return (
     <SearchHeadlessContext.Provider value={generateMockedHeadless({
       ...mockedHeadlessState,
@@ -59,11 +54,11 @@ export const Loading = (args: AlternativeVerticalsProps) => {
       }
     })}>
       <AlternativeVerticals
-        currentVerticalLabel='Jobs'
-        verticalConfigMap={verticalConfigMap}
-        displayAllOnNoResults={true}
         {...args}
       />
     </SearchHeadlessContext.Provider>
   );
 };
+Loading.args = {
+  ...DisplayAllOnNoResults.args
+};
diff --git a/tests/components/AppliedFilters.stories.tsx b/tests/components/AppliedFilters.stories.tsx
@@ -1,9 +1,9 @@
-import { ComponentMeta } from '@storybook/react';
+import { ComponentMeta, Story } from '@storybook/react';
 import { SearchHeadlessContext, SearchTypeEnum } from '@yext/search-headless-react';
 
 import { generateMockedHeadless } from '../__fixtures__/search-headless';
-import { AppliedFiltersDisplay } from '../../src/components/AppliedFiltersDisplay';
-import { AppliedFiltersProps, builtInCssClasses } from '../../src/components/AppliedFilters';
+import { AppliedFiltersDisplay, AppliedFiltersDisplayProps } from '../../src/components/AppliedFiltersDisplay';
+import { builtInCssClasses } from '../../src/components/AppliedFilters';
 import { RemovableFilters } from '../__fixtures__/data/filters';
 
 const meta: ComponentMeta<typeof AppliedFiltersDisplay> = {
@@ -12,7 +12,7 @@ const meta: ComponentMeta<typeof AppliedFiltersDisplay> = {
 };
 export default meta;
 
-export const Primary = (args: AppliedFiltersProps) => {
+export const Primary: Story<AppliedFiltersDisplayProps> = (args) => {
   return (
     <SearchHeadlessContext.Provider value={generateMockedHeadless({
       meta: { searchType: SearchTypeEnum.Vertical }
@@ -26,4 +26,3 @@ export const Primary = (args: AppliedFiltersProps) => {
     </SearchHeadlessContext.Provider>
   );
 };
-