Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

Only allow route: T: Switch in Props to Anchor and Button components. #207

Closed
hgzimmerman opened this issue Dec 17, 2019 · 0 comments · Fixed by #210
Closed

Only allow route: T: Switch in Props to Anchor and Button components. #207

hgzimmerman opened this issue Dec 17, 2019 · 0 comments · Fixed by #210
Labels
breaking change This change will result in a broken build or differing behavior in end-user crates. enhancement New feature or request high priority Issues with this tag will be worked on before others

Comments

@hgzimmerman
Copy link
Member

Description

To make it impossible to represent a non-valid internal route, using route: T instead of link: String, state: T would be a significant improvement to the props on the RouterAnchor and RouterButton.

This obviously would be a breaking change, but ultimately makes it easier to construct valid routes.
@hgzimmerman hgzimmerman added enhancement New feature or request high priority Issues with this tag will be worked on before others breaking change This change will result in a broken build or differing behavior in end-user crates. labels Dec 17, 2019
@hgzimmerman hgzimmerman mentioned this issue Dec 18, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change This change will result in a broken build or differing behavior in end-user crates. enhancement New feature or request high priority Issues with this tag will be worked on before others
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Anchor and Button components use Switch in Props yewstack/yew_router
1 participant
@hgzimmerman