Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

Remove ambiguity regarding ! token after {capture} token #148

Closed
hgzimmerman opened this issue Oct 24, 2019 · 0 comments · Fixed by #152
Closed

Remove ambiguity regarding ! token after {capture} token #148

hgzimmerman opened this issue Oct 24, 2019 · 0 comments · Fixed by #152
Labels
enhancement New feature or request high priority Issues with this tag will be worked on before others

Comments

@hgzimmerman
Copy link
Member

Description

Placing a ! after capture block is not allowed (but this restriction is only partially applied, which is also not ideal). This is done because some code in next_delimiter would panic if it encounters a End token instead of an exact.

Ideally the ! should be allowed after capture blocks, but next_delimiter and the functions that utilize it may need to change in order to allow this.
@hgzimmerman hgzimmerman added enhancement New feature or request high priority Issues with this tag will be worked on before others labels Oct 24, 2019
@hgzimmerman hgzimmerman mentioned this issue Oct 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request high priority Issues with this tag will be worked on before others
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow ! after capture yewstack/yew_router
1 participant
@hgzimmerman