-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: shift to pydantic #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes in the caller functions (i.e. py_lsp_client). Are there any changes needed?
I also added some tests that might fail now, can you please check that as well?
Thanks for you support! Much appreciated
Of course. Will look into it. |
I looked into. But I could not get this converted to pydantic. I will have to do more research on this. The trouble is the the type identifier is pointing to a class that inherits a threading module and keeps throwing an "Unable to generate pydantic-core schema" error. There is perhaps another way to convert it. |
I added an example PR of shifting one class into pydantic. You can take a look and let me know what you thinkg |
I added another class to Pydantic, you can see it here: #42 |
Kindly give me some time. |
No problem, thanks for your effort |
The test cases are failing. Is this due to changes done in the class. I can look into them |
assert set(symbol.name for symbol in symbols) == set(expected_symbols) is failing. symbols is coming up empty. Should I configure anything? |
I have changed all I can to the best of my ability. Please check |
Modified classes to basemodel of pydantic where possible