Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: shift to pydantic #38

Closed
wants to merge 9 commits into from
Closed

FIX: shift to pydantic #38

wants to merge 9 commits into from

Conversation

eadaradhiraj
Copy link

Modified classes to basemodel of pydantic where possible

@eadaradhiraj eadaradhiraj mentioned this pull request Dec 7, 2023
@yeger00 yeger00 self-requested a review December 7, 2023 18:51
Copy link
Owner

@yeger00 yeger00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes in the caller functions (i.e. py_lsp_client). Are there any changes needed?
I also added some tests that might fail now, can you please check that as well?

Thanks for you support! Much appreciated

pylspclient/lsp_structs.py Outdated Show resolved Hide resolved
@eadaradhiraj
Copy link
Author

I don't see any changes in the caller functions (i.e. py_lsp_client). Are there any changes needed? I also added some tests that might fail now, can you please check that as well?

Thanks for you support! Much appreciated

Of course. Will look into it.

@eadaradhiraj
Copy link
Author

I don't see any changes in the caller functions (i.e. py_lsp_client). Are there any changes needed? I also added some tests that might fail now, can you please check that as well?
Thanks for you support! Much appreciated

Of course. Will look into it.

I looked into. But I could not get this converted to pydantic. I will have to do more research on this. The trouble is the the type identifier is pointing to a class that inherits a threading module and keeps throwing an "Unable to generate pydantic-core schema" error. There is perhaps another way to convert it.

@yeger00
Copy link
Owner

yeger00 commented Dec 16, 2023

I added an example PR of shifting one class into pydantic. You can take a look and let me know what you thinkg

#40

@yeger00 yeger00 linked an issue Dec 16, 2023 that may be closed by this pull request
@yeger00
Copy link
Owner

yeger00 commented Dec 21, 2023

I added another class to Pydantic, you can see it here: #42
Let me know if you want to join me in moving the rest of these.

@eadaradhiraj
Copy link
Author

I added another class to Pydantic, you can see it here: #42 Let me know if you want to join me in moving the rest of these.

Kindly give me some time.

@yeger00
Copy link
Owner

yeger00 commented Dec 21, 2023

No problem, thanks for your effort

@eadaradhiraj
Copy link
Author

The test cases are failing. Is this due to changes done in the class. I can look into them

@eadaradhiraj
Copy link
Author

assert set(symbol.name for symbol in symbols) == set(expected_symbols) is failing.

symbols is coming up empty.

Should I configure anything?

@eadaradhiraj
Copy link
Author

I have changed all I can to the best of my ability. Please check

@eadaradhiraj eadaradhiraj closed this by deleting the head repository Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pydantic
2 participants