Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp_structs.LinkLocation is referenced in lisp_client.py but doesn't seem to exist #24

Closed
briandw opened this issue Apr 28, 2023 · 2 comments · Fixed by #41
Closed

lsp_structs.LinkLocation is referenced in lisp_client.py but doesn't seem to exist #24

briandw opened this issue Apr 28, 2023 · 2 comments · Fixed by #41

Comments

@briandw
Copy link

briandw commented Apr 28, 2023

The class lsp_structs.LinkLocation is referenced in the functions declaration and definition of the lsp_client.py file.

Here's the spec:
https://microsoft.github.io/language-server-protocol/specifications/specification-3-15/#textDocument_declaration

I'll see about implementing this.
However it doesn't look like this repo is taking PRs right now.
If anyone is interested, give a thumbs up.

@briandw
Copy link
Author

briandw commented Apr 28, 2023

Scratch that, it's just that the class is called LocationLink. Clearly no one has used this feature before.

@yeger00 yeger00 linked a pull request Dec 16, 2023 that will close this issue
@briandw
Copy link
Author

briandw commented Dec 17, 2023

Thanks @yeger00 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant