Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Possible for strategies to be misgrouped on the risk page #289

Open
0xkofee opened this issue Mar 28, 2022 · 0 comments
Open

Possible for strategies to be misgrouped on the risk page #289

0xkofee opened this issue Mar 28, 2022 · 0 comments

Comments

@0xkofee
Copy link
Contributor

0xkofee commented Mar 28, 2022

When the risk page is loaded for the group Single Sided Balancer https://yearn.watch/network/ethereum/query/default/group/SingleSidedBalancer,SSBv2/

It's missing some strategies that end up in the Others bucket: here

Notice the other's bucket contains [SingleSidedBalancer staBAL3Pool USDC. This is just one example so there may be more. I've confirmed that the query for strategies with names like singlesidedbalancer just returns one strategy from the helper contract which is wrong.

This occurs because the address isn't registered in the helper contract. See 0x7A32aA9a16A59CB335ffdEe3dC94024b7F8A9a47 and then search for it in the method assetsStrategiesAddresses

https://github.com/yearn/yearn-watch/blob/master/src/utils/strategiesHelper.ts#L41-L47

I wonder if this is to be expected if the strategy is no longer in use... ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant