Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl C doesn't work, Microsoft recommend not using cmd in new software, yarn.cmd and yarnpkg.cmd should be ps1 #6092

Open
mikemaccana opened this issue Jul 12, 2018 · 1 comment
Open

Ctrl C doesn't work, Microsoft recommend not using cmd in new software, yarn.cmd and yarnpkg.cmd should be ps1 #6092

mikemaccana opened this issue Jul 12, 2018 · 1 comment

Comments

@mikemaccana
Copy link
Contributor

mikemaccana commented Jul 12, 2018 •
edited
Loading

Per microsoft/terminal#217 - originally created when I wanted to be able to Ctrl-C things like yarn and gulp without being confirmed - Microsoft strongly recommend against creating new .cmd files.

From various Microsoft staff (and echoed repeatedly in microsoft/terminal#217)

If you're writing Windows Command-Line scripts today, they should be PowerShell scripts wherever possible

Moving yarn.cmd and yarnpkg.cmd (which are tiny) to .ps1 would allow users to cancel them without having a silly confirmation prompot, and probably also avoid other unforeseen drama due to cmd being unmaintained.

Happy to send a PR, just wanted to discuss first.
mikemaccana pushed a commit to mikemaccana/yarn that referenced this issue Jul 12, 2018
Make Windows command executable use powershell rather than cmd. Fixes y…
a688174 
…arnpkg#6092
@mikemaccana mikemaccana mentioned this issue Jul 12, 2018
Merged
@mikemaccana mikemaccana changed the title Ctrl C doesn't work, cmd is no longer maintained, yarn.cmd and yarnpkg.cmd should be ps1 Ctrl C doesn't work, Microsoft recommend not using cmd in new software, yarn.cmd and yarnpkg.cmd should be ps1 Jul 13, 2018
@SettingDust
Copy link

It's seems that the PR had beedn merged? Is it fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemaccana @SettingDust