feat(why): allow specifying a version or range #6992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

remypar5 wants to merge 11 commits into yarnpkg:master from remypar5:feat/6859-allow-version-range-for-yarn-why

+379 −19

.yarn/versions/b4b98142.yml

-Original file line number
+Diff line change
@@ -0,0 +1,36 @@
+    releases:
+      "@yarnpkg/cli": minor
+      "@yarnpkg/core": minor
+      "@yarnpkg/plugin-essentials": minor
+    declined:
+      - "@yarnpkg/plugin-catalog"
+      - "@yarnpkg/plugin-compat"
+      - "@yarnpkg/plugin-constraints"
+      - "@yarnpkg/plugin-dlx"
+      - "@yarnpkg/plugin-exec"
+      - "@yarnpkg/plugin-file"
+      - "@yarnpkg/plugin-git"
+      - "@yarnpkg/plugin-github"
+      - "@yarnpkg/plugin-http"
+      - "@yarnpkg/plugin-init"
+      - "@yarnpkg/plugin-interactive-tools"
+      - "@yarnpkg/plugin-jsr"
+      - "@yarnpkg/plugin-link"
+      - "@yarnpkg/plugin-nm"
+      - "@yarnpkg/plugin-npm"
+      - "@yarnpkg/plugin-npm-cli"
+      - "@yarnpkg/plugin-pack"
+      - "@yarnpkg/plugin-patch"
+      - "@yarnpkg/plugin-pnp"
+      - "@yarnpkg/plugin-pnpm"
+      - "@yarnpkg/plugin-stage"
+      - "@yarnpkg/plugin-typescript"
+      - "@yarnpkg/plugin-version"
+      - "@yarnpkg/plugin-workspace-tools"
+      - "@yarnpkg/builder"
+      - "@yarnpkg/doctor"
+      - "@yarnpkg/extensions"
+      - "@yarnpkg/nm"
+      - "@yarnpkg/pnpify"
+      - "@yarnpkg/sdks"

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-1.0.0/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-1.0.0/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,4 @@
+    {
+        "name": "why-no-deps",
+        "version": "1.0.0"
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-1.1.0/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-1.1.0/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,4 @@
+    {
+        "name": "why-no-deps",
+        "version": "1.1.0"
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-1.1.1/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-1.1.1/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,4 @@
+    {
+        "name": "why-no-deps",
+        "version": "1.1.1"
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-2.0.0/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-no-deps-2.0.0/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,4 @@
+    {
+        "name": "why-no-deps",
+        "version": "2.0.0"
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.0.0/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.0.0/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+        "name": "why-range-dep",
+        "version": "1.0.0",
+        "dependencies": {
+            "why-no-deps": "^1.0.0"
+        }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.0.1/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.0.1/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+        "name": "why-range-dep",
+        "version": "1.0.1",
+        "dependencies": {
+            "why-no-deps": "^1.0.1"
+        }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.1.0/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.1.0/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+        "name": "why-range-dep",
+        "version": "1.1.0",
+        "dependencies": {
+            "why-no-deps": "^1.1.0"
+        }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.1.1/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-1.1.1/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+        "name": "why-range-dep",
+        "version": "1.1.1",
+        "dependencies": {
+            "why-no-deps": "^1.1.1"
+        }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-2.0.0/index.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    module.exports = require(`./package.json`);
+    for (const key of [`dependencies`, `devDependencies`, `peerDependencies`]) {
+      for (const dep of Object.keys(module.exports[key] || {})) {
+        module.exports[key][dep] = require(dep);
+      }
+    }

packages/acceptance-tests/pkg-tests-fixtures/packages/why-range-dep-2.0.0/package.json

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    {
+        "name": "why-range-dep",
+        "version": "2.0.0",
+        "dependencies": {
+            "why-no-deps": "^2.0.0"
+        }
+    }

packages/acceptance-tests/pkg-tests-specs/sources/commands/why.test.ts

clemyan marked this conversation as resolved.

Show resolved Hide resolved

-Original file line number
+Diff line change
@@ Expand Up / @@ -207,5 +207,182 @@ describe(`Commands`, () => { @@
             }]);
           }),
         );
+        describe(`with a specified version`, () => {
+          test(
+            `it should list workspaces using a specific version range`,
+            makeTemporaryEnv({
+              workspaces: [`packages/*`],
+            }, async ({path, run, source}) => {
+              await fs.writeJson(ppath.join(path, `packages/a/package.json`), {
+                name: `a`,
+                dependencies: {
+                  [`b`]: `workspace:^`,
+                  [`c`]: `workspace:^`,
+                  [`why-no-deps`]: `1.0.0`,
+                },
+              });
+              await fs.writeJson(ppath.join(path, `packages/b/package.json`), {
+                name: `b`,
+                dependencies: {
+                  [`why-no-deps`]: `1.1.0`,
+                },
+              });
+              await fs.writeJson(ppath.join(path, `packages/c/package.json`), {
+                name: `c`,
+                dependencies: {
+                  [`why-no-deps`]: `2.0.0`,
+                },
+              });
+              await run(`install`);
+              const {stdout} = await run(`why`, `why-no-deps@^1.1.0`, `--json`);
+              // Don't list v1.0.0 (package A) nor v2.0.0 (package C)
+              expect(misc.parseJsonStream(stdout)).toEqual([{
+                value: `b@workspace:packages/b`,
+                children: {
+                  [`why-no-deps@npm:1.1.0`]: {
+                    descriptor: `why-no-deps@npm:1.1.0`,
+                    locator: `why-no-deps@npm:1.1.0`,
+                  },
+                },
+              }]);
+            }));
+          test(
+            `it should list workspaces transitively using a specific version range`,
+            makeTemporaryEnv({
+              workspaces: [`packages/*`],
+            }, async ({path, run, source}) => {
+              await fs.writeJson(ppath.join(path, `packages/a/package.json`), {
+                name: `a`,
+                dependencies: {
+                  [`b`]: `workspace:^`,
+                  [`why-range-dep`]: `1.0.0`,
+                },
+              });
+              await fs.writeJson(ppath.join(path, `packages/b/package.json`), {
+                name: `b`,
+                dependencies: {
+                  [`c`]: `workspace:^`,
+                  [`why-range-dep`]: `1.1.0`,
+                },
+              });
+              await fs.writeJson(ppath.join(path, `packages/c/package.json`), {
+                name: `c`,
+                dependencies: {
+                  [`d`]: `workspace:^`,
+                  [`why-range-dep`]: `1.1.1`,
+                },
+              });
+              await fs.writeJson(ppath.join(path, `packages/d/package.json`), {
+                name: `d`,
+                dependencies: {
+                  [`why-range-dep`]: `2.0.0`,
+                },
+              });
+              await run(`install`);
+              const {stdout} = await run(`why`, `-R`, `why-no-deps@^1.1.0`, `--json`);
+              // Don't list v1.0.0 (package A) nor v2.0.0 (package D)
+              expect(stdout).not.toContain(`why-no-deps@npm:1.0.0`);
+              expect(stdout).not.toContain(`why-no-deps@npm:1.0.1`);
+              expect(stdout).not.toContain(`why-no-deps@npm:2.0.0`);
+              expect(misc.parseJsonStream(stdout)).toEqual([{
+                value: `a@workspace:packages/a`,
+                children: {
+                  [`b@workspace:packages/b`]: {
+                    children: {},
+                    value: {
+                      descriptor: `b@workspace:^`,
+                      locator: `b@workspace:packages/b`,
+                    },
+                  },
+                  [`why-range-dep@npm:1.0.0`]: {
+                    value: {
+                      descriptor: `why-range-dep@npm:1.0.0`,
+                      locator: `why-range-dep@npm:1.0.0`,
+                    },
+                    children: {
+                      [`why-no-deps@npm:1.1.1`]: {
+                        children: {},
+                        value: {
+                          descriptor: `why-no-deps@npm:^1.0.0`,
+                          locator: `why-no-deps@npm:1.1.1`,
+                        },
+                      },
+                    },
+                  },
+                },
+              }, {
+                value: `b@workspace:packages/b`,
+                children: {
+                  [`c@workspace:packages/c`]: {
+                    children: {},
+                    value: {
+                      descriptor: `c@workspace:^`,
+                      locator: `c@workspace:packages/c`,
+                    },
+                  },
+                  "why-range-dep@npm:1.1.0": {
+                    children: {
+                      "why-no-deps@npm:1.1.1": {
+                        children: {},
+                        value: {
+                          descriptor: `why-no-deps@npm:^1.1.0`,
+                          locator: `why-no-deps@npm:1.1.1`,
+                        },
+                      },
+                    },
+                    value: {
+                      descriptor: `why-range-dep@npm:1.1.0`,
+                      locator: `why-range-dep@npm:1.1.0`,
+                    },
+                  },
+                },
+              }, {
+                value: `c@workspace:packages/c`,
+                children: {
+                  [`why-range-dep@npm:1.1.1`]: {
+                    value: {
+                      descriptor: `why-range-dep@npm:1.1.1`,
+                      locator: `why-range-dep@npm:1.1.1`,
+                    },
+                    children: {
+                      [`why-no-deps@npm:1.1.1`]: {
+                        children: {},
+                        value: {
+                          descriptor: `why-no-deps@npm:^1.1.1`,
+                          locator: `why-no-deps@npm:1.1.1`,
+                        },
+                      },
+                    },
+                  },
+                },
+              }]);
+            }));
+          test(`it should fail with non-semver range specified`, makeTemporaryEnv({
+            workspaces: [`packages/*`],
+          }, async ({path, run, source}) => {
+            /*
+            Since we're testing if the given range is invalid (non-semver), it fails
+            even before traversing the dependency-tree. We don't have to create a
+            whole environment here bit rather just run an invalid command in the
+            current workspace.
+            */
+            expect(async () => await run(`why`, `irrelevant-dependency@invalid.range`)).rejects.toThrow();
+          }));
+        });
       });
     });

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(why): allow specifying a version or range #6992

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

feat(why): allow specifying a version or range #6992

Are you sure you want to change the base?

feat(why): allow specifying a version or range #6992

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!