Adds support for multiple concurrent runtimes #630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Some packages need to be able to require files from other dependency trees. This isn't possible at the moment, because the PnP runtime covers all
require
calls.How did you fix it?
Basically module instances are now "namespaced" based on their PnP API path. When a require call is made to a file that doesn't belong to the original runtime, we find out whether a new runtime could cover it by tracking the closest
.pnp.js
file in the hierarchy. We then load it and use it.Some extra subtleties:
eslint-disable
in their headers to prevent accidental linting$$virtual
, and will always be transformed no matter their location. This change was required because the PnP hook didn't know what were the virtual paths for the other runtimes than the initial one.