Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner component action sent to wormhole component instead of outer component (canary) #33

Closed
mdehoog opened this issue Sep 16, 2015 · 2 comments

Comments

@mdehoog
Copy link

mdehoog commented Sep 16, 2015

Using Ember canary, when an "outer" component has an "inner" component that's inside a wormhole, and the "inner" component sends an action, the action is fired on the wormhole itself, causing the error:

Uncaught Error: <emberapp@component:ember-wormhole::ember609> had no action handler for: actionName

It used to be fired correctly on the "outer" component, but is broken since emberjs/ember.js#12289.

I've also raised an issue on the ember.js repository: emberjs/ember.js#12317, but thought the issue may be able to fixed on the ember-wormhole side, or you might have some insight into how to fix the regression.

Note that this is only an error if the "inner" component and wormhole are defined in an "outer" component template; the action works fine if the component/wormhole are in a controller template.

This fiddle reproduces the issue: http://ember-twiddle.com/1c59a1dcdb18eec69a8e. Changing the ember dependency from canary to release in twiddle.json fixes the issue.

@mdehoog
Copy link
Author

mdehoog commented May 5, 2016

Seems to be fixed, see comment in emberjs/ember.js#12317.

@mdehoog mdehoog closed this as completed May 5, 2016
@lukemelia
Copy link
Contributor

👍 Thanks for following up, @mdehoog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants