-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add v18.20.2 patch #35
Conversation
@keegan-w I have reverted nodejs 20 patches as seems the one I created is broken. If you want to take a look at that too let me know so I can wait before doing new release 🙏🏼 |
Fixes #31 |
@keegan-w Did you try to run the pkg-fetch locally with --test flag to test the binary? Just run the command |
I ran that test on windows and it completed successfully :) , i've also been testing the built binary inside my web server application and it has continued to work as previously. Not sure how much time I'll get to look at the Node 20 issues though.... Seemed like there a few people wanting this version with the latest node js security updates (myself included 😄), so it may helpful to publish a release in the interim. |
@keegan-w news about this? |
The issue is:
By doing some research seems this is a known issue related to the glibc version nodejs/node#52223 The suggested fix is to patch a nodejs file like explained here: tsibley/conda-forge-nodejs-feedstock@5eb5c33 |
I have just submitted two fixes that should fix both linux and mac builds |
Fixes #31
I've created patch for 18.20.2.
Please review when you get a chance. Thanks in advance