Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v18.20.2 patch #35

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

keegan-w
Copy link

@keegan-w keegan-w commented May 23, 2024

Fixes #31

I've created patch for 18.20.2.

Please review when you get a chance. Thanks in advance

@robertsLando
Copy link
Member

@keegan-w I have reverted nodejs 20 patches as seems the one I created is broken. If you want to take a look at that too let me know so I can wait before doing new release 🙏🏼

@robertsLando
Copy link
Member

Fixes #31

@robertsLando
Copy link
Member

robertsLando commented May 23, 2024

@keegan-w Did you try to run the pkg-fetch locally with --test flag to test the binary?

Just run the command yarn start --test --force-build --node-range node18

@keegan-w
Copy link
Author

I ran that test on windows and it completed successfully :) , i've also been testing the built binary inside my web server application and it has continued to work as previously.

Not sure how much time I'll get to look at the Node 20 issues though.... Seemed like there a few people wanting this version with the latest node js security updates (myself included 😄), so it may helpful to publish a release in the interim.

@robertsLando robertsLando merged commit 36e3726 into yao-pkg:main May 24, 2024
5 checks passed
@robertsLando
Copy link
Member

@robertsLando
Copy link
Member

@keegan-w news about this?

@robertsLando
Copy link
Member

robertsLando commented Jun 13, 2024

The issue is:

#17 146.5 ../deps/cares/src/lib/ares_rand.c:39:12: fatal error: sys/random.h: No such file or directory
#17 146.5    39 | #  include <sys/random.h>
#17 146.5       |            ^~~~~~~~~~~~~~
#17 146.5 compilation terminated.
#17 146.5 make[1]: *** [deps/cares/cares.target.mk:199: /tmp/pkg.5b572aede55a6d701bf2fd33/node/out/Release/obj.target/cares/deps/cares/src/lib/ares_rand.o] Error 1
#17 146.5 make[1]: *** Waiting for unfinished jobs....
#17 146.6 make: *** [Makefile:134: node] Error 2

By doing some research seems this is a known issue related to the glibc version nodejs/node#52223

The suggested fix is to patch a nodejs file like explained here: tsibley/conda-forge-nodejs-feedstock@5eb5c33

@robertsLando
Copy link
Member

I have just submitted two fixes that should fix both linux and mac builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 18.20.1 security release
3 participants