Add jsx-uses-react rule #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule somewhat unusual, in that it modifies the behaviour of a core eslint rule. The alternative would be to copy-paste the original rule and modify it. That would require users to disable the core rule and replace with this one
glenjamin
force-pushed
the
jsx-uses-react
branch
from
46b9c97
to
ca87883
Compare
2 similar comments
|
Thanks! This is a tricky case to check but I am agree with your approach to use the Like you said it breaks the separation of rules but I can't really see any other way to check this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eslint/eslint#1905 for additional context.
This rule somewhat unusual, in that it modifies the behaviour of a core eslint rule.
I'm not hugely keen on this, but it does work. It is possible for the rule to be broken by changes in eslint core.
The alternative would be to copy-paste the original rule and modify it.
That would require users to disable the core rule and replace it with this one - and then any improvements to the core rule would have to be tracked here and updated.
Of those two choices, I think the first one is the most practical, even if it breaks the usual clean separation of rules.