make jsx-handler-names error messages less specific #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the checks have failed? |
yannickcr
added a commit
that referenced
this pull request
Dec 5, 2015
Update jsx-handler-names error messages to be less specific
|
Thanks.
Just a very small coverage decrease because you removed some tested lines, not an error for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized the error messages were previously specifying a more specific method name than the rule actually enforced.
For example,
onChange={this.itemClicked}would throw the warningHandler function for onChange prop key must be named handleChange, when reallythis.handleItemClickwould (and should) pass.