Skip to content

[Fix] no-render-return-value should warn when used in assignment expression. #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ljharb merged 1 commit into from
Oct 12, 2019
Merged

[Fix] no-render-return-value should warn when used in assignment expression. #2462

ljharb merged 1 commit into from
Oct 12, 2019

Conversation

@jichu4n
Copy link
Contributor

@jichu4n jichu4n commented Oct 11, 2019

Addresses #2461 .

With this PR, the no-render-return-value plugin will warn for usages like this:

this.x = ReactDOM.render(...);

or

let y;
...
y = ReactDOM.render(...);

@jichu4n jichu4n mentioned this pull request Oct 11, 2019
Closed
ljharb
ljharb approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit da2c7d2 into jsx-eslint:master Oct 12, 2019
@jichu4n jichu4n deleted the render-assignment branch October 12, 2019 05:21
This was referenced Dec 11, 2019
Closed
Open
This was referenced Feb 12, 2020
Open
Merged
This was referenced Mar 6, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Mar 20, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 21, 2020
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jichu4n @ljharb