Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2381-fix camelCase error in jsx-sort-props #2391

Merged
merged 1 commit into from
Aug 31, 2019
Merged

2381-fix camelCase error in jsx-sort-props #2391

merged 1 commit into from
Aug 31, 2019

Conversation

tanmoyopenroot
Copy link
Contributor

PR checklist

Overview of change:

use localCompare rather than comparison operator

@ljharb ljharb added the bug label Aug 23, 2019
@tanmoyopenroot
Copy link
Contributor Author

Hi @ljharb ,
As it is approved, Can you merge it?

@ljharb
Copy link
Member

ljharb commented Aug 31, 2019

Thanks for the ping; it's in my queue. I should be able to get to it tonight.

@ljharb ljharb force-pushed the 2381-fix-camelCase-error-in-jsx-sort-props branch from 534d183 to 398b7d7 Compare August 31, 2019 06:01
@ljharb ljharb merged commit 398b7d7 into jsx-eslint:master Aug 31, 2019
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@hawkrives hawkrives mentioned this pull request Dec 21, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 21, 2020
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react/jsx-sort-props gets confused when props are sorted with --fix but one has camelCase
2 participants
@tanmoyopenroot @ljharb