[Feat]: jsx-pascal-case allowAllCaps allows underscore #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jul 31, 2019
ljharb
reviewed
Jul 31, 2019
tests/lib/rules/jsx-pascal-case.js
Outdated
| }, { | ||
| code: '<TEST_COMPONENT_ />', | ||
| options: [{allowAllCaps: true}], | ||
| errors: [{message: 'Imported JSX component TEST_COMPONENT_ must be in PascalCase'}] |
There was a problem hiding this comment.
seems like the message, when allowAllCaps, should say "in PascalCase or SCREAMING_SNAKE_CASE"?
ljharb
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I hope this finds you well.
My team uses a custom tool for Localization and by convention we've adopted an all-caps snake case for "Translatable Strings" like
<TS_USER_INPUT />or<TS_ADD_BUTTON />to facilitate that.Our ESLint configs fell out of date as we moved to adopt TypeScript, during which we've written hundreds of these new components. Now that I'm trying to refresh and re-enable them, the
jsx-pascal-caserule is throwing tons of errors. I like what it's trying to do, though, so I don't want to turn it off. If I had more time I'd try to makeignoreaccept Regex patterns like/^TS_[A-Z0-9]+$/but I figure enabling Snake Case with theallowAllCapsrule is a simple enough change for most people as it doesn't seem like a breaking change to me.I hope it meets with your approval! Thanks for your time.