Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-unescaped-entities to recommended configuration #841

Closed
lencioni opened this issue Sep 16, 2016 · 2 comments
Closed

Add no-unescaped-entities to recommended configuration #841

lencioni opened this issue Sep 16, 2016 · 2 comments
Assignees
Milestone

Comments

@lencioni
Copy link
Collaborator

This rule was added by #681 and I think it should be added to the recommended configuration for the next major version bump.

@lencioni lencioni added this to the 7.0.0 milestone Sep 16, 2016
@ljharb ljharb self-assigned this Apr 23, 2017
@ljharb ljharb closed this as completed in c6c5e3b Apr 23, 2017
@rauchg
Copy link

rauchg commented May 15, 2017

@ljharb I'm curious what the downsides are to not escaping '? Makes writing stuff pretty difficult, but I'm sure there's a good reason

@ljharb
Copy link
Member

ljharb commented May 15, 2017

@rauchg The rule documentation should explain it; basically, it's highly likely there's a bug.

Separately, it shouldn't impact "writing stuff" at all, since straight quotes are typographically incorrect, and you don't need to escape curly quotes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants