-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False Missing "key" prop for element in iterator
from jsx-key
#320
Comments
I am also noticing that this gives false errors on pure functional stateless components that are now available as of React 0.14: const MyComponent = () =>
<div>
...
</div>; |
eslint-plugin-react naively checks just if the element is a part of an arrow expression. I'm setting up a PR… |
yannickcr
added a commit
that referenced
this issue
Dec 22, 2015
Fix jsx-key false-positives (fixes #320)
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, great work on the jsx-key rule. I think this will save people a lot of time.
Now, I have the following code:
using the jsx-key rule, I am getting the missing key prop on the line that has the opening
<div>
. I might be misunderstanding whenkey
should be used, but I don't think I need one here. And, if I do, then the error message that this rule outputs is misleading since it claims that I am in an iterator when I am not.I noticed in the documentation:
which I believe is referring to this situation, but I figured I'd open an issue for this anyway in case there happens to be a solution lurking.
The text was updated successfully, but these errors were encountered: