Fix prop-types crash with Flow spread operator (fixes #1178)

jsx-eslint · May 7, 2017 · dd10133 · dd10133 · ljharb · May 7, 2017
1 parent 7f53bdb
commit dd10133
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -678,6 +678,10 @@ module.exports = {
       switch (propTypes && propTypes.type) {
         case 'ObjectTypeAnnotation':
           iterateProperties(propTypes.properties, function(key, value) {
+            if (!value) {
+              ignorePropsValidation = true;
+              return;
+            }
             declaredPropTypes[key] = buildTypeAnnotationDeclarationTypes(value);
           });
           break;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1428,6 +1428,20 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'type Person = {',
+        '  ...data,',
+        '  lastname: string',
+        '};',
+        'class Hello extends React.Component {',
+        '  props: Person;',
+        '  render () {',
+        '    return <div>Hello {this.props.firstname}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],