Strict commandline (pytorch#157)

* add strict commandline enforcement

* strict commandline enforcement capability

* commandline enforcement vs warning

* fix typo

* typo

Author: mikekgfb

cli.py

@@ -13,6 +13,33 @@
 
 default_device = "cpu"  # 'cuda' if torch.cuda.is_available() else 'cpu'
 
+strict = False
+
+def check_args(args, command_name: str):
+    global strict
+
+    # chat and generate support the same options
+    if command_name in  ["generate", "chat", "gui"]:
+        # examples, can add more. Note that attributes convert dash to _
+        disallowed_args = ['output_pte_path', 'output_dso_path' ]
+    elif command_name == "export":
+        # examples, can add more. Note that attributes convert dash to _
+        disallowed_args = ['pte_path', 'dso_path' ]
+    elif command_name == "eval":
+        # TBD
+        disallowed_args = []
+    else:
+        raise RuntimeError(f"{command_name} is not a valid command")
+    
+    for disallowed in disallowed_args:
+        if args.hasattr(disallow):
+            text = f"command {command_name} does not support option {disallowed.replace('_', '-')}"
+            if strict:
+                raise RuntimeError(text)
+            else:
+                print(f"Warning: {text}")
+
+    
 def cli_args():
     import argparse
 

eval.py

@@ -28,7 +28,7 @@
 except:
     lm_eval_available = False
 
-from generate import _load_model, encode_tokens, model_forward
+from generate import _load_inference_model, encode_tokens, model_forward
 
 if lm_eval_available:
     try: # lm_eval version 0.4

torchat.py

@@ -23,10 +23,12 @@ def cli():
     args = cli_args()
 
     if args.generate or args.chat:
+        check_args(args, "generate")
         generate_main(args)
     elif args.eval:
         eval_main(args)
     elif args.export:
+        check_args(args, "export")
         export_main(args)
     else:
         raise RuntimeError("must specify either --generate or --export")