Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_to_epoch_logger() mistake?This should be placed outside the for loop. #8

Open
WILLOSCAR opened this issue Mar 13, 2023 · 0 comments

Comments

@WILLOSCAR
Copy link

As we can see, there are four functions for train. I found a problem, In train_epoch function which is baseline, write_to_epoch_logger() are excuted after finishing the batch calculation("for" loop). But in the other 3 training functions(train_a_epoch, train_i_epoch, train_ai_epoch), that write_to_epoch_logger() function is inside the for loop which is different from the baseline. This should be placed outside the for loop.
Meanwhile that write_to_epoch_logger() function's write log argument should be avg, not val. If you use val, it means that you are using the acc of the last input in this batch, not the average acc of the whole batch。
If my understanding is wrong, please correct me! I would be grateful if you could reply as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant