Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convenience methods in __init__.py should modify FullLoader instead of Loader #271

Closed
dthkao opened this issue Mar 15, 2019 · 3 comments
Closed
Labels

Comments

@dthkao
Copy link
Contributor

dthkao commented Mar 15, 2019

For example add_constructor() in 5.1 is a no-op for legacy code since it adds the constructor to Loader but FullLoader is the one used in load(input).

https://github.com/yaml/pyyaml/blob/master/lib3/yaml/__init__.py#L329-L344

@perlpunk
Copy link
Member

Thanks, we're discussing this. It will always break some code, but since the default for load is FullLoader that seems to be the best.

@perlpunk
Copy link
Member

I created #274

@perlpunk
Copy link
Member

perlpunk commented Dec 9, 2019

This was fixed in 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants