Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up rl-human-prefs-api #3

Closed
yamatokataoka opened this issue Dec 20, 2021 · 5 comments · Fixed by #5
Closed

set up rl-human-prefs-api #3

yamatokataoka opened this issue Dec 20, 2021 · 5 comments · Fixed by #5
Assignees
@yamatokataoka
Milestone
v0.1.0 MVP

Comments

@yamatokataoka
Copy link
Owner

yamatokataoka commented Dec 20, 2021 •
edited
Loading

  • add a project structure with Go
  • add Dockerfile
  • add linters
@yamatokataoka yamatokataoka moved this from Todo to In Progress in learning-from-human-preferences Dec 20, 2021
@yamatokataoka yamatokataoka self-assigned this Dec 20, 2021
@yamatokataoka yamatokataoka added this to the v0.0.1 MVP milestone Dec 20, 2021
@yamatokataoka
Copy link
Owner Author

Golint is deprecated and frozen.

@yamatokataoka
Copy link
Owner Author

yamatokataoka commented Dec 28, 2021 •
edited
Loading

it seems there are a lot of linters out there.
https://about.sourcegraph.com/go/gophercon-2019-go-linters-myths-and-best-practices/

@yamatokataoka
Copy link
Owner Author

golangci-lint seems useful as a Go linters aggregator.

@yamatokataoka
Copy link
Owner Author

let's start from default config with gofmt to find out which ones are useful.

@yamatokataoka yamatokataoka linked a pull request Dec 28, 2021 that will close this issue
Set up rl human prefs api #5
Merged
Repository owner moved this from In Progress to Done in learning-from-human-preferences Dec 28, 2021
@yamatokataoka
Copy link
Owner Author

Docker command for Go development

docker run --rm -it \
 --name go-dev \
 -u $(id -u):$(id -g) \
 -w /app \
 -v $PWD:/app \
 -p 8080:8080 \
 -e GOCACHE=/tmp/.cache golang:1.17.4-alpine sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yamatokataoka yamatokataoka

Labels
None yet
Projects
learning-from-human-preferences
Status: Done
Milestone
v0.1.0 MVP
Development

Successfully merging a pull request may close this issue.

Set up rl human prefs api yamatokataoka/learning-from-human-preferences
1 participant
@yamatokataoka