diff --git a/.agents/commands/code/review-loop.md b/.agents/commands/code/review-loop.md new file mode 100644 index 000000000..3b687e611 --- /dev/null +++ b/.agents/commands/code/review-loop.md @@ -0,0 +1,20 @@ +--- +description: Iterative review-and-fix loop +--- + +Repeat the following cycle on the current branch's changes against `main` (max 3 iterations): + +1. **Review** — Spawn 6 agents in parallel, each reviewing the current diff from a different angle: + - **Agent 1 — Code quality**: Bugs, logic errors, edge cases, code smells + - **Agent 2 — Security**: Vulnerabilities, injection risks, secret exposure, unsafe patterns + - **Agent 3 — Performance**: Inefficiencies, resource leaks, unnecessary allocations + - **Agent 4 — Test coverage**: Missing tests, untested edge cases, test quality + - **Agent 5 — Conventions**: Project conventions (.agents/rules/base.md), naming, structure + - **Agent 6 — Holistic review**: Overall design concerns, side effects of changes, integration risks that individual agents may miss + Each agent should only report noteworthy findings. +2. **Triage** — Review agent findings and keep only what you also deem noteworthy. Classify each as **Fix** (clear defects, must fix) or **Skip** (style, nitpicks, scope creep). Show a brief table before changing anything. +3. **Fix** only the "Fix" items. Keep changes minimal. +4. **Verify** with `npm run lint` and `npm run test`. Fix any regressions and repeat this step until all checks pass before continuing. +5. **Re-review** only the newly changed lines. Do not re-raise skipped items. + +Stop when no "Fix" items remain or 3 iterations are reached. Print a summary of what was fixed and what was skipped.