Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial Untrusted DoS vuln #18

Closed
skull-squadron opened this issue May 22, 2017 · 7 comments
Closed

Trivial Untrusted DoS vuln #18

skull-squadron opened this issue May 22, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@skull-squadron
Copy link

skull-squadron commented May 22, 2017

Version 0.4.0. This means affecting hex packages and other packages like yaml_elixir.

Impact Launching observer, it shows consuming all CPU by running in infinite loop and growing memory without bound.

Vuln For responsible disclosure practices, an email address with an associated GPG public key (maybe one of these) is needed to transfer specifics. If no reply is made, it will be publicly disclosed 2 months from today.

@skull-squadron
Copy link
Author

Confirmed on master as well.

@skull-squadron
Copy link
Author

I've manually reduced the pattern-space, and have some eunit tests.

It seems wise to consider QuickCheck/Mini, PropEr or other property/type fuzzing because YAML is complex and difficult to get right (400+ hits on CVEMITRE).

@dumbbell
Copy link
Collaborator

Hi!

Thank you for doing this analysis. You can reach me at one of the uids of my PGP key.

@dumbbell dumbbell self-assigned this May 23, 2017
@skull-squadron
Copy link
Author

Will do daytime.

Looked at QuickCheck Mini* for property testing. Fuzzing utf8/16/32, lexical, syntactic and document levels seems to make sense.

* EULA is short isn't too awful (not BSD) and the reducer is superior compared to triq and PropEr.

More QuickCheck packages

@skull-squadron
Copy link
Author

Email sent.

@skull-squadron
Copy link
Author

Here's an expanded EUnit test for this issue (deep-link to a private repo)

@skull-squadron
Copy link
Author

skull-squadron commented Jun 12, 2017

LGTM (tested, couldn't break it) 🍻

Thanks for releasing too.

@dumbbell dumbbell added this to the v0.5.0 milestone Mar 23, 2018
@dumbbell dumbbell added the bug label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants