Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align with fluxible-router, pass props #87

Merged
merged 1 commit into from
Apr 8, 2016
Merged

align with fluxible-router, pass props #87

merged 1 commit into from
Apr 8, 2016

Conversation

kaesonho
Copy link
Contributor

@kaesonho kaesonho commented Apr 8, 2016

@MattHo @redonkulus @lingyan

it's for aligning with https://github.com/yahoo/fluxible/blob/master/packages/fluxible-router/lib/createNavLinkComponent.js#L127,

in case users put I13nMixin and NavLink together, and integrate shouldFollowLink, should pass props and provide the same API, otherwise will see js error

@redonkulus
Copy link
Contributor

👍

@yahoocla
Copy link

yahoocla commented Apr 8, 2016

CLA is valid!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.267% when pulling a19d570 on passprops into fa495e2 on master.

@kaesonho kaesonho merged commit 1ddfc96 into master Apr 8, 2016
@kaesonho kaesonho deleted the passprops branch April 8, 2016 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants