Prevent multiple copies of express-state from overwriting expose()
#4
Conversation
This removes top-level vars in favor of describe-scoped vars.
If more than one copy of express-state is loaded, because of dependency issues, it will not plugin into the same copy of express more than once.
|
/cc @caridy |
ghost
assigned 
| expect = require('chai').expect, | ||
| express = require('express'), |
There was a problem hiding this comment.
You use the original express modules for some tests, while mocking it for some other tests, that seems a little tricky. Can we guarantee that those tests are going to be executed in order? Is it absolutely necessary to use the real express instead of a mock for all tests?
If there is no way, or it is too difficult to accomplish, then I will say that the multiple copies test should be moved out of this file into its own test file that uses mockery.
Good point, I'll do that instead. |
This moves the express mock and dynamic `require()` loading via mockery into its own test file.
|
@caridy I updated this to move the |
| @@ -49,6 +42,16 @@ describe('state', function () { | |||
| }); | |||
|
|
|||
| describe('global .local', function () { | |||
| var origLocal; | |||
|
|
|||
| beforeEach(function () { | |||
There was a problem hiding this comment.
It is ok to have all this on every test for now, but if you use mockery to require and create a new app on every test, there is not need to restore original values.
There was a problem hiding this comment.
Yeah, I could switch this to use Mockery to re-load the express-state module every time. But I don't want to mock it, since this is explicitly trying to test that functionality.
|
+1 |
Prevent multiple copies of express-state from overwriting `expose()`
If more than one copy of express-state is loaded, because of dependency issues, it will not plugin into the same copy of express more than once.