Express 4.x #29
Express 4.x #29
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
| @@ -244,7 +244,7 @@ describe('state', function () { | |||
| expect(res.locals.state).to.have.ownProperty('bar'); | |||
| expect(res.locals.state.bar).to.equal('bar'); | |||
|
|
|||
| expect(app.locals).to.have.ownProperty('state'); | |||
| expect(app.locals).to.have.property('state'); | |||
There was a problem hiding this comment.
Do you know why you had to change this from ownProperty to property?
There was a problem hiding this comment.
Ah ha! It looks like app.locals is now created via Object.create(null): https://github.com/visionmedia/express/blob/master/lib/application.js#L63
https://github.com/visionmedia/express/blob/master/lib/middleware/init.js#L21
|
@NoumanSaleem thanks for doing this! Could you sign the Yahoo CLA here: #29 (comment) ? Then I'll merge and release this. |
|
@ericf No problem. Good to see you, Nouman |
|
Thanks again @NoumanSaleem. Released as |
|
@ericf no problem! |
Passing tests using Express 4.0.0