Add cache option to improve serialization performance
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common for data being exposed to not change between requests (this
is most common for app-level data); this change adds support for a
`cache` option which signal express-state that it's safe to cache and
reused the serialized form of the data.
app.expose(constConfig, 'config', {cache: true});
This fixes an issue with namespaces to make the following work as
expected:
app.expose('foo', 'window.foo');
console.log(res.locals.state); // => window.foo = "foo";
app.expose('bar', 'window.bar');
console.log(res.locals.state); // => window.foo = "foo";
This also brings test coverage back to 100% and adds more code comments.
ghost
assigned 
| }, this); | ||
|
|
||
| // Stores the new exposed namespace and its current value. | ||
| namespaces.push(namespace); | ||
| this[namespace] = value; | ||
|
|
||
| // When it's deemed safe to cache the serialized form of the `value` becuase | ||
| // it won't change, run the serialization process once, egarly. The result |
|
@drewfish thanks for finding my typos :) |
|
LGTM |
| }); | ||
|
|
||
| it('should inherit new namespaces', function () { | ||
| it('should inherit new namespaces form super', function () { |
There was a problem hiding this comment.
typo: should inherit new namespaces from super
ericf
added a commit
that referenced
this pull request
Jan 23, 2014
Add `cache` option to improve serialization performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for exposed values to not change during the lifetime of an app or request once they've been passed to the
app.expose()orres.expose()methods. When this is the case, thecacheoption can be set which signals Express State that it's safe to eagerly serialize the value, making repeated calls toExposed#toString()much more efficient.The most common use case for the
cacheoption is for app-level data which doesn't change, like configuration:Benchmarks
The follow are the benchmarks comparing
masterwith this branch.mastercacheTodos
expose( obj [, namespace [, local]] )API