Avoid truncating URLs in unquoted hrefs #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/close
branch
from
971afd0 to
773467d
Compare
charliermarsh
force-pushed
the
charlie/close
branch
from
773467d to
7ba5576
Compare
charliermarsh
commented
Aug 15, 2024
| @@ -163,7 +162,7 @@ impl<'a> Parser<'a> { | |||
| let value = if let Some(quote) = self.stream.expect_oneof_and_skip(&[b'"', b'\'']) { | |||
| self.read_to(quote) | |||
| } else { | |||
| self.read_to4([b' ', b'\n', b'/', b'>']) | |||
| self.read_to3([b' ', b'\n', b'>']) | |||
There was a problem hiding this comment.
Per MDN, if the / isn't separated from the unquoted value by whitespace, it should be treated as part of the value. So I think it's correct to just omit it entirely here.
There was a problem hiding this comment.
|
👋 Anything I can do to help this along? I'd prefer not to fork but also want to unblock our users. Thank you! |
|
This is a polite ping about merging and releasing this fix. As primary maintainer of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68.