From 5feb1a0be4f8bcd1693a116ee8d66330f58e79e3 Mon Sep 17 00:00:00 2001 From: davidlion Date: Wed, 7 May 2025 15:26:40 -0400 Subject: [PATCH 1/4] fix(lint-configs): Relax clang-tidy `misc-include-cleaner` to a warning --- exports/lint-configs/.clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exports/lint-configs/.clang-tidy b/exports/lint-configs/.clang-tidy index b3491fc..e8aa6dc 100644 --- a/exports/lint-configs/.clang-tidy +++ b/exports/lint-configs/.clang-tidy @@ -1,5 +1,5 @@ FormatStyle: "file" -WarningsAsErrors: "*" +WarningsAsErrors: "*,-misc-include-cleaner" # Disabled checks: # - `bugprone-easily-swappable-parameters` because it's difficult to mitigate. From d84f2fd73cd13503de5871bace118fd66f905720 Mon Sep 17 00:00:00 2001 From: davidlion Date: Wed, 7 May 2025 16:04:21 -0400 Subject: [PATCH 2/4] Improve style. --- exports/lint-configs/.clang-tidy | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/exports/lint-configs/.clang-tidy b/exports/lint-configs/.clang-tidy index e8aa6dc..10f3e67 100644 --- a/exports/lint-configs/.clang-tidy +++ b/exports/lint-configs/.clang-tidy @@ -1,5 +1,11 @@ FormatStyle: "file" -WarningsAsErrors: "*,-misc-include-cleaner" + +# Left as warnings: +# - `misc-include-cleaner` because it's difficult to resolve iwyu issues for external libraries +# without facade headers. +WarningsAsErrors: >- + * + -misc-include-cleaner # Disabled checks: # - `bugprone-easily-swappable-parameters` because it's difficult to mitigate. From e84e93aa8bae29004c58867edebaa359753101ae Mon Sep 17 00:00:00 2001 From: davidlion Date: Wed, 7 May 2025 19:43:01 -0400 Subject: [PATCH 3/4] Apply suggestions from code review. Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> --- exports/lint-configs/.clang-tidy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exports/lint-configs/.clang-tidy b/exports/lint-configs/.clang-tidy index 10f3e67..f07c30c 100644 --- a/exports/lint-configs/.clang-tidy +++ b/exports/lint-configs/.clang-tidy @@ -1,10 +1,10 @@ FormatStyle: "file" # Left as warnings: -# - `misc-include-cleaner` because it's difficult to resolve iwyu issues for external libraries +# - `misc-include-cleaner` because it's difficult to resolve IWYU issues for external libraries # without facade headers. WarningsAsErrors: >- - * + *, -misc-include-cleaner # Disabled checks: From d6f841cc6834584f59c5e0cb827733bb06407232 Mon Sep 17 00:00:00 2001 From: davidlion Date: Wed, 7 May 2025 19:50:30 -0400 Subject: [PATCH 4/4] Add comma. --- exports/lint-configs/.clang-tidy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exports/lint-configs/.clang-tidy b/exports/lint-configs/.clang-tidy index f07c30c..1b00f10 100644 --- a/exports/lint-configs/.clang-tidy +++ b/exports/lint-configs/.clang-tidy @@ -5,7 +5,7 @@ FormatStyle: "file" # without facade headers. WarningsAsErrors: >- *, - -misc-include-cleaner + -misc-include-cleaner, # Disabled checks: # - `bugprone-easily-swappable-parameters` because it's difficult to mitigate.