From dcbea2b288bdfe717168c7ae164b5b2f3b717602 Mon Sep 17 00:00:00 2001 From: Xiaochong Wei Date: Mon, 9 Jun 2025 13:02:53 -0400 Subject: [PATCH 1/4] Add CodeRabbit config --- .coderabbit.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .coderabbit.yaml diff --git a/.coderabbit.yaml b/.coderabbit.yaml new file mode 100644 index 00000000000..31ed9a7b57b --- /dev/null +++ b/.coderabbit.yaml @@ -0,0 +1,23 @@ +# Copyright (c) Facebook, Inc. and its affiliates. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json +language: "en-CA" +reviews: + path_instructions: + - path: "**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}" + instructions: >- + - Prefer `false == ` rather than `!`. + profile: "assertive" + poem: false \ No newline at end of file From 9f9bd50d49260608ae3cb2ae5d59f5d102acc298 Mon Sep 17 00:00:00 2001 From: Xiaochong Wei Date: Mon, 9 Jun 2025 13:09:43 -0400 Subject: [PATCH 2/4] Add header file --- .coderabbit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 31ed9a7b57b..c7146d54949 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -16,7 +16,7 @@ language: "en-CA" reviews: path_instructions: - - path: "**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}" + - path: "**/*.{cpp,h,hpp,java,js,jsx,tpp,ts,tsx}" instructions: >- - Prefer `false == ` rather than `!`. profile: "assertive" From f5a079b1647aeade6e39bed72e59dcc545c49c3d Mon Sep 17 00:00:00 2001 From: Xiaochong Wei Date: Mon, 9 Jun 2025 18:12:35 -0400 Subject: [PATCH 3/4] Fix --- .coderabbit.yaml | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index c7146d54949..1a79a516548 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -1,17 +1,3 @@ -# Copyright (c) Facebook, Inc. and its affiliates. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json language: "en-CA" reviews: From b4726bb5be4bfbfb1bf66416d4b2b469b8699d9a Mon Sep 17 00:00:00 2001 From: Xiaochong Wei Date: Tue, 10 Jun 2025 12:45:25 -0400 Subject: [PATCH 4/4] Fix --- .coderabbit.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 1a79a516548..5632602cc37 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -1,9 +1,5 @@ # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json language: "en-CA" reviews: - path_instructions: - - path: "**/*.{cpp,h,hpp,java,js,jsx,tpp,ts,tsx}" - instructions: >- - - Prefer `false == ` rather than `!`. profile: "assertive" - poem: false \ No newline at end of file + poem: false