From eec3532a0f538829f0d77a23bfcf2f2660245ce1 Mon Sep 17 00:00:00 2001 From: Sitao Wang Date: Sat, 30 Nov 2024 21:33:25 +0000 Subject: [PATCH 1/2] Revert "fix: Lock task to v3.39.2 to work around behaviour change in v3.40.0. (#22)" This reverts commit 6e1c7f1b5ee5eae7b4b0cd2ac236985d7208b9bd. --- .devcontainer/Dockerfile | 6 ++---- .github/workflows/code-linting-checks.yaml | 5 +---- README.md | 2 +- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 401c33c17..67e8146f8 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -10,10 +10,8 @@ RUN ./tools/scripts/lib_install/linux/install-dev.sh RUN ./tools/scripts/lib_install/linux/install-lib.sh # NOTE: -# - `task` doesn't have an apt/yum package so we use its install script. -# - We lock task's version since v3.40.0 and higher change the behaviour of how undefined variables -# are treated in `ref` statements, causing yscope-dev-utils' `validate-checksum` task to fail. -RUN sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d -b /usr/local/bin v3.39.2 +# `task` doesn't have an apt/yum package so we use its install script. +RUN sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d -b /usr/local/bin # Remove cached files RUN apt-get clean \ diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index 750b8b471..d4bb15ef8 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -31,11 +31,8 @@ jobs: with: python-version: "3.10" - # We lock task's version since v3.40.0 and higher change the behaviour of how undefined - # variables are treated in `ref` statements, causing yscope-dev-utils' `validate-checksum` - # task to fail. - name: "Install task" - run: "npm install -g @go-task/cli@3.39.2" + run: "npm install -g @go-task/cli" - if: "matrix.os == 'macos-latest'" name: "Install coreutils (for md5sum)" diff --git a/README.md b/README.md index 9e6e141d1..89c772457 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ Follow the steps below to develop and contribute to the project. ## Requirements * Python 3.10 or higher -* [Task] >= 3.38.0, < 3.40.0 +* [Task] 3.38.0 or higher ## Set up Initialize and update submodules: From 1b05e2f84d8b80d04ce7d66fe724ca314711fee9 Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Sat, 30 Nov 2024 16:57:37 -0500 Subject: [PATCH 2/2] Update yscope-dev-utils with fix to task v3.40.0 --- tools/yscope-dev-utils | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/yscope-dev-utils b/tools/yscope-dev-utils index 159768c7d..ad576e43c 160000 --- a/tools/yscope-dev-utils +++ b/tools/yscope-dev-utils @@ -1 +1 @@ -Subproject commit 159768c7d171595ed2cba17b758c10043a2efe96 +Subproject commit ad576e43c1a43d7a6afde79fc9c3c952b7bf28bd