From d6e906504dd9a47defacd5070a8d292aa10efad0 Mon Sep 17 00:00:00 2001
From: Parth Halani <parthhalani05@gmail.com>
Date: Fri, 1 Nov 2024 13:00:20 +0530
Subject: [PATCH] Add spotbugs exclusions

---
 pom.xml              |  1 +
 spotbugs-exclude.xml | 49 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 spotbugs-exclude.xml

diff --git a/pom.xml b/pom.xml
index 6aa4e7d..5f241a7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -189,6 +189,7 @@
         <configuration>
           <effort>Max</effort>
           <includeTests>true</includeTests>
+          <excludeFilterFile>${project.basedir}/spotbugs-exclude.xml</excludeFilterFile>
         </configuration>
       </plugin>
 
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
new file mode 100644
index 0000000..836aaa4
--- /dev/null
+++ b/spotbugs-exclude.xml
@@ -0,0 +1,49 @@
+<FindBugsFilter>
+  <Match>
+    <Bug category="BAD_PRACTICE" code="CT" value="CT_CONSTRUCTOR_THROW" />
+    <Class name="com.yscope.logging.log4j2.AbstractBufferedRollingFileAppender" />
+    <Justification>Log4j2 should throw immediately if configurations are wrong</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="BAD_PRACTICE" code="CT" value="CT_CONSTRUCTOR_THROW" />
+    <Class name="com.yscope.logging.log4j2.ClpIrFileAppender" />
+    <Justification>Log4j2 should throw immediately if configurations are wrong</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="BAD_PRACTICE" code="CT" value="CT_CONSTRUCTOR_THROW" />
+    <Class name="com.yscope.logging.log4j2.CompressionPatternLayoutContainer" />
+    <Justification>Log4j2 should throw immediately if configurations are wrong</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="MALICIOUS_CODE" code="EI" value="EI_EXPOSE_REP" />
+    <Class name="com.yscope.logging.log4j2.PatternLayoutBufferDestination" />
+    <Justification>Simply returning the buffer. No security check required. False positive</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="PERFORMANCE" code="UrF" value="URF_UNREAD_FIELD" />
+    <Class name="com.yscope.logging.log4j2.AbstractBufferedRollingFileAppender$Builder" />
+    <Justification>Log4j2 plugin attributes. False positive</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="PERFORMANCE" code="UrF" value="URF_UNREAD_FIELD" />
+    <Class name="com.yscope.logging.log4j2.AbstractClpIrBufferedRollingFileAppender$Builder" />
+    <Justification>Log4j2 plugin attributes. False positive</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="PERFORMANCE" code="UrF" value="URF_UNREAD_FIELD" />
+    <Class name="com.yscope.logging.log4j2.ClpIrFileAppender$Builder" />
+    <Justification>Log4j2 plugin attributes. False positive</Justification>
+  </Match>
+
+  <Match>
+    <Bug category="MT_CORRECTNESS" code="IS" value="IS2_INCONSISTENT_SYNC" />
+    <Class name="com.yscope.logging.log4j2.AbstractBufferedRollingFileAppender" />
+    <Justification>Custom synchronization is for shutdown after all user threads</Justification>
+  </Match>
+</FindBugsFilter>
\ No newline at end of file