From 795c10618e86fa2f626a107238d4d959eb4e86c3 Mon Sep 17 00:00:00 2001 From: Bingran Hu Date: Thu, 21 Nov 2024 23:19:09 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com> --- components/core/src/clp/streaming_compression/Compressor.hpp | 2 +- .../core/src/clp/streaming_compression/zstd/Compressor.cpp | 2 +- components/core/tests/test-StreamingCompression.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/components/core/src/clp/streaming_compression/Compressor.hpp b/components/core/src/clp/streaming_compression/Compressor.hpp index 4963fbc13..f1bfecb4e 100644 --- a/components/core/src/clp/streaming_compression/Compressor.hpp +++ b/components/core/src/clp/streaming_compression/Compressor.hpp @@ -13,7 +13,7 @@ namespace clp::streaming_compression { /** - * Generic compressor interface. + * Abstract compressor interface. */ class Compressor : public WriterInterface { public: diff --git a/components/core/src/clp/streaming_compression/zstd/Compressor.cpp b/components/core/src/clp/streaming_compression/zstd/Compressor.cpp index cbfabbe89..0ab9abe9c 100644 --- a/components/core/src/clp/streaming_compression/zstd/Compressor.cpp +++ b/components/core/src/clp/streaming_compression/zstd/Compressor.cpp @@ -24,7 +24,7 @@ namespace { * 2. A size_t <-> error_code_enum mapping function `ZSTD_getErrorCode`. * See also: https://facebook.github.io/zstd/zstd_manual.html * - * @param result A `size_t` type result returned by ZStd functions + * @param result A `size_t` type result returned from ZStd APIs * @return Whether the result is an error code and indicates an error has occurred */ auto is_error(size_t result) -> bool { diff --git a/components/core/tests/test-StreamingCompression.cpp b/components/core/tests/test-StreamingCompression.cpp index f3083a1cc..42fbb0721 100644 --- a/components/core/tests/test-StreamingCompression.cpp +++ b/components/core/tests/test-StreamingCompression.cpp @@ -37,7 +37,7 @@ TEST_CASE("StreamingCompression", "[StreamingCompression]") { cBufferSize / 2, cBufferSize} ); - constexpr size_t cAlphabetLength = 26; + constexpr size_t cAlphabetLength{26}; std::string const compressed_file_path{"test_streaming_compressed_file.bin"}; // Initialize compression devices