Skip to content

feat: Add C++ Presto Worker plugin. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
20001020ycx merged 12 commits into from
May 25, 2026
Merged

feat: Add C++ Presto Worker plugin. #4

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ebec41e
feat: Add Velox CLP connector source code
20001020ycx May 11, 2026
4a942e9
feat: Migrate Presto worker's deserialization protocol.
20001020ycx May 12, 2026
a91b4d6
feat: add CMake files and plugin entry point.
20001020ycx May 11, 2026
a705429
Update velox-connector/CMakeLists.txt
20001020ycx May 20, 2026
c85362f
Address reviewer's comments
20001020ycx May 20, 2026
ccfd450
fix regression during refactor
20001020ycx May 20, 2026
77f89fa
Apply suggestions from code review
20001020ycx May 21, 2026
9d4fb25
address kirk's comment
20001020ycx May 21, 2026
4e86724
Merge branch 'main' into feat/2026-05-11-velox-connector-initialization
20001020ycx May 21, 2026
9158de6
update the output shared library name to libclp-plugin-velox-connecto…
20001020ycx May 21, 2026
73abbfd
Merge branch 'feat/2026-05-11-velox-connector-initialization' of gith…
20001020ycx May 21, 2026
2ab4abc
Update velox-connector/CMakeLists.txt
20001020ycx May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix regression during refactor
  • Loading branch information
@20001020ycx
20001020ycx committed May 20, 2026
commit ccfd4502fb4d58817fa3c5266ad0988a8ea34ac8
20 changes: 10 additions & 10 deletions velox-connector/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
# Enable -fPIC for all targets so STATIC libraries can be linked into a shared library.
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

# Match Presto worker's AVX2 flags to satisfy Folly's F14LinkCheck<Mode> symbol.
#
# Including Folly's F14 headers emits a call to F14LinkCheck<Mode>, where Mode
Comment thread
20001020ycx marked this conversation as resolved.
Resolved
# is determined at compile time by the CPU flags. This plugin includes Presto
# worker's headers, which pull in Folly's F14 headers transitively. Presto
# worker is built with AVX2 (Mode 2); if this plugin is built without it, it
# emits a call to F14LinkCheck<1>, which Presto worker does not provide,
# causing dlopen to fail with an unresolved symbol error.
Comment thread
20001020ycx marked this conversation as resolved.
Resolved
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mavx2")

Comment thread
20001020ycx marked this conversation as resolved.
Resolved
# ==============================================================================
# 1. Presto/Velox framework headers
Comment thread
20001020ycx marked this conversation as resolved.
Resolved
# ==============================================================================
Expand Down Expand Up @@ -63,16 +73,6 @@ add_library(presto_clp_plugin SHARED
src/ClpPrestoToVeloxConnector.cpp
)

# Match Presto worker's AVX2 flags to satisfy Folly's F14LinkCheck<Mode> symbol.
#
# Including Folly's F14 headers emits a call to F14LinkCheck<Mode>, where Mode
# is determined at compile time by the CPU flags. This plugin includes Presto
# worker's headers, which pull in Folly's F14 headers transitively. Presto
# worker is built with AVX2 (Mode 2); if this plugin is built without it, it
# emits a call to F14LinkCheck<1>, which Presto worker does not provide,
# causing dlopen to fail with an unresolved symbol error.
target_compile_options(presto_clp_plugin PRIVATE -mavx2)

target_include_directories(presto_clp_plugin
PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/src
Expand Down